From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D82C433EF for ; Tue, 15 Mar 2022 09:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346410AbiCOJMH (ORCPT ); Tue, 15 Mar 2022 05:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235268AbiCOJMG (ORCPT ); Tue, 15 Mar 2022 05:12:06 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E14E4A930; Tue, 15 Mar 2022 02:10:54 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 15B301F4362D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647335452; bh=NwX7z9yLH6PqPXHH+1YrRwrLzO3ovt+3Z5XpGrvmKS8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iWNEK+EpnG3jNZMRjecHpsAmeWU6zFOS6k+qgB74qBXGs+LW7sSjpJOXrcrBqTRQ5 dLI9AV5kUClDmqbYN24ZiH0mr0hbYViFwh/2WqETWTP3Ajk6R/rUU3dFCgHiMpi+sb neLKSRxcsKbd/1HU+7Epg43kd8wajdwMQ6rw6dEd/0v3/b22UoNNSPG47j6d8TZLyt Qe3il/g3wzCJYGKiF85wX3Olx/3aj20ncDtHxkYmlve+qojo0dBWdc7Bm3l1PQua81 6rZH593fCyvmA99xqjP75hgaht2QjmQGFVMV2pQH7AgF+aQt4BGsI5pym+DPzH6YcZ 4pXR7t076RMRg== Message-ID: Date: Tue, 15 Mar 2022 10:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v13 1/6] soc: mediatek: mutex: add common interface to accommodate multiple modules operationg MUTEX Content-Language: en-US To: Moudy Ho , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec Cc: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Courbot , tfiga@chromium.org, drinkcat@chromium.org, pihsun@chromium.org, hsinyi@google.com, Maoguang Meng , daoyuan huang , Ping-Hsun Wu , menghui.lin@mediatek.com, sj.huang@mediatek.com, allen-kh.cheng@mediatek.com, randy.wu@mediatek.com, jason-jh.lin@mediatek.com, roy-cw.yeh@mediatek.com, river.cheng@mediatek.com, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220315061031.21642-1-moudy.ho@mediatek.com> <20220315061031.21642-2-moudy.ho@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220315061031.21642-2-moudy.ho@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 15/03/22 07:10, Moudy Ho ha scritto: > In order to allow multiple modules to operate MUTEX hardware through > a common interfrace, a flexible index "mtk_mutex_table_index" needs to > be added to replace original component ID so that like DDP and MDP > can add their own MUTEX table settings independently. > > In addition, 4 generic interface "mtk_mutex_set_mod", "mtk_mutex_set_sof", > "mtk_mutex_clear_mod" and "mtk_mutex_clear_sof" have been added, which is > expected to replace the "mtk_mutex_add_comp" and "mtk_mutex_remove_comp" > pair originally dedicated to DDP in the future. > > Signed-off-by: Moudy Ho > --- > drivers/soc/mediatek/mtk-mutex.c | 122 +++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-mutex.h | 33 +++++++ > 2 files changed, 155 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c > index aaf8fc1abb43..778b01ce9e8f 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -156,6 +156,7 @@ struct mtk_mutex_data { > const unsigned int *mutex_sof; > const unsigned int mutex_mod_reg; > const unsigned int mutex_sof_reg; > + const unsigned long long *mutex_table_mod; Can we change this to u64 instead? With that done, Reviewed-by: AngeloGioacchino Del Regno