From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88212C7EE25 for ; Wed, 10 May 2023 19:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236338AbjEJT5F (ORCPT ); Wed, 10 May 2023 15:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjEJT5C (ORCPT ); Wed, 10 May 2023 15:57:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ECEA2126; Wed, 10 May 2023 12:57:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 807186354A; Wed, 10 May 2023 19:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51A0AC433EF; Wed, 10 May 2023 19:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683748620; bh=DCbaf6xVpFEDtn0H7lDuPNgtj7JSCv0rwyzi3AwTjg4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LzQpL+4LP9d3GVhwXGOeQaNXtUMYBB8t+NORX9vmt1hf193JvWXJRgjvPg5+V7crn Ab3x3CQk19I5VvbTxQY5TMR9AlLLiD2qtD1pgQJTBYuO+Du7qj/zbp9t2O4yVCMlqH F2B4mFpllWNaOviTJiUWY0ifTir5vQwWNkH92RP0g78GAjnAkElHqr4IsjyxBwKhZw y3VubZG0brs+vC+QTjXOYXFgHlqNB5jn9E9+yWTcAyafp6/1Lquljsei+DxARO8uEU zRWn1u15DFmFru4fnJKPV1bwGt/mMOz2SEr/SX+nSIPjdnhziPeTif2E0s4PXu7k9j x56C6kstXMtsA== Message-ID: Date: Wed, 10 May 2023 13:56:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [net 2/2] selftets: seg6: disable rp_filter by default in srv6_end_dt4_l3vpn_test Content-Language: en-US To: Andrea Mayer , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam , Hangbin Liu References: <20230510111638.12408-1-andrea.mayer@uniroma2.it> <20230510111638.12408-3-andrea.mayer@uniroma2.it> From: David Ahern In-Reply-To: <20230510111638.12408-3-andrea.mayer@uniroma2.it> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/23 5:16 AM, Andrea Mayer wrote: > On some distributions, the rp_filter is automatically set (=1) by > default on a netdev basis (also on VRFs). > In an SRv6 End.DT4 behavior, decapsulated IPv4 packets are routed using > the table associated with the VRF bound to that tunnel. During lookup > operations, the rp_filter can lead to packet loss when activated on the > VRF. > Therefore, we chose to make this selftest more robust by explicitly > disabling the rp_filter during tests (as it is automatically set by some > Linux distributions). > > Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior") > Reported-by: Hangbin Liu > Signed-off-by: Andrea Mayer > Tested-by: Hangbin Liu > --- > .../testing/selftests/net/srv6_end_dt4_l3vpn_test.sh | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > Reviewed-by: David Ahern