mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liuyixian (Eason)" <liuyixian@huawei.com>
To: Colin King <colin.king@canonical.com>,
	Lijun Ou <oulijun@huawei.com>, "Wei Hu" <xavier.huwei@huawei.com>,
	Doug Ledford <dledford@redhat.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers
Date: Tue, 27 Mar 2018 15:14:36 +0800	[thread overview]
Message-ID: <ed57c631-94ec-82ad-8621-12f36bb017e1@huawei.com> (raw)
In-Reply-To: <20180326151018.21066-1-colin.king@canonical.com>



On 2018/3/26 23:10, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd.  Fix this by setting i correctly.

Hi Colin,

Thank you very much for this patch! It's a typo when I prepared the patch set.

Reviewed-by: Yixian Liu <liuyixian@huawei.com>

> 
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
> 
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 684c2d1a0ed0..8b84ab7800d8 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -4391,7 +4391,7 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
>  	eq->l0_dma = 0;
>  
>  	if (mhop_num == 1)
> -		for (i -= i; i >= 0; i--)
> +		for (i -= 1; i >= 0; i--)
>  			dma_free_coherent(dev, buf_chk_sz, eq->buf[i],
>  					  eq->buf_dma[i]);
>  	else if (mhop_num == 2) {
> 

  reply	other threads:[~2018-03-27  7:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 15:10 Colin King
2018-03-27  7:14 ` Liuyixian (Eason) [this message]
2018-03-27 21:08 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed57c631-94ec-82ad-8621-12f36bb017e1@huawei.com \
    --to=liuyixian@huawei.com \
    --cc=colin.king@canonical.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=oulijun@huawei.com \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®