From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC842E8882 for ; Thu, 26 Mar 2026 05:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774502156; cv=none; b=hMcxJTtzVPsL0PTVlXfvzuVYFqCvU8+hgoIqIjn3e8u2VLbvGauYG0syFytnYXfnidpI6duaY6oSRVGcTMAb2WQ4heDjF7pxxUGXW4DTABGJeBBAxBa2i/V3YI31G0br1VXeV2a10xR4VM0VTz3IC/ZLT0VWp+qo7SiQYAcguxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774502156; c=relaxed/simple; bh=jIngtV7lw3vPEhiv+DRkYdMmvxbPvbNnD20qR2/tSR4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S0utUt19jCIFsxqwmf8Uhdiu6gz0/KthG+Kbu1vX3RV3dJdKr6T0RmI1tyERBaqslJG7/YcH/M9ASK+NjBc7qIUxfQsqoxAHOvWLlGDxigiOw2PSTOUgB+2dFPrpUztOejOR67lxJf14a18fV9yHBHOj+i3bSAv31AwngCYpC+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CQ3A9Tl/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UN0wCaDI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CQ3A9Tl/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UN0wCaDI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PKwEvK1175626 for ; Thu, 26 Mar 2026 05:15:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9+aohIFgcTJgc8zRGatBOt8jhkb+aMJkB0K86/2Xfvo=; b=CQ3A9Tl/XxcWHKAN SlGMI6cntLsZjD2CbAhVtLqxUppsjfgLV47sVhwAiNLlRLpcmpi9zizvir8vW9pf BN7vmnp0lldpLHimpg7O0lOM/n4VIS+aDaKeaidqJiymBTI3WeU3jo1ZEYt0E5oX 198Km3pVGrQ7LxkduOyi0/YNnSy3S71xcsBHOQLzTn7XZRWl61h3+Mt9vVY7hJH5 I0aLBxfKs8OmD/aso9v+LyeVQYHd/X4cTLFwkDALtgMvCSkPaimrNgTNT7AGdYrn 4URML9ZPxNCRfFnY45t98B0BS2Nf+Loo8vFs7OueFUIj1hL8uny11Y9It8T+GmEM Ub6hQg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4q76s9aw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 05:15:53 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c6ea0e59784so94090a12.1 for ; Wed, 25 Mar 2026 22:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774502153; x=1775106953; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9+aohIFgcTJgc8zRGatBOt8jhkb+aMJkB0K86/2Xfvo=; b=UN0wCaDI92UyT41dWWR0AhpwXuiLcRjemg//2p1YXN2wbJIAXWD2wWvhCpWjz6Slsd /W1gRq/PX00ABuS8fGn6RZx+99ruP87YmbCXv2L7SeZa/PMPipyGGYRdII0Q5Dxu02Js YtDSt7L3S8h00Oe1BSnPre6sFZn/spNhBir694z53LdYm8W4Xoy2Z2vpZtQ69pwJie9a oS31nV/dflaGeHCGkMHP1RZ517OOW3HbLZV8d3G/XY3CuL3aveB1Rg1bzh4t6VlvL8uR wXGMOdHBY1g23CE9velvJYBC7LdkMVAgRAmE8vDCDaW70V4KUgkjOqZmhXBdnIiVwpbw gkOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774502153; x=1775106953; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9+aohIFgcTJgc8zRGatBOt8jhkb+aMJkB0K86/2Xfvo=; b=Ej2f7xuVfk9GWHOPEfoMBd/b3YY75KDUrDBzp0QK5QPG0KT9ZwtrzQDnmfcVKi0CTD KB/jPPpLcGKQt+LeP1D83ocXidLl9GQlZllsUbpHZa6ahPQAZZ8IqDAn1ULKXv/3s06o 5OH3C8kyjayvKyT1Yao+696YiJVf1iAjkDHdfFb5gM7F3nIkEZ0jf0sTx8X9YWlEOyn5 7YBEVpV0QUcQO2vsBxoq8mPGuL4TAESB/3izvw2oOz3r/D4JSG9NwqVvo9AYaOFkEiDw fDPoyunfdWrj2YnwWLwoDL6pyzaGngKZNQua2T7L+aMpGx/m5Rvd8xjXtNyhQp+IkYCw pOfQ== X-Forwarded-Encrypted: i=1; AJvYcCULHTVks/PulLBt2j1YrkdHDfhARvmYmx5Tkpqg+W+yaq6r6qncdwdBeAYYMKL+qLNzgnKtvYPI5+ZCnv8=@vger.kernel.org X-Gm-Message-State: AOJu0YxkQDEZt/pqrOWqOWVyDOAFhv/IOihsk8U9wjVjng51XRRJjN2j GIz/c31F4TAl8PAgB7eNvp2u0SOJlskbjksupsGb8FXAaKDHCGJLGJj/x2U/z80NKgEhnTS7V0y /775xLjgE8vyyjlQSUVXZH2Nw0Sx5JsID6xLngZvsNu2I+QJD1yRwdHpkZ1cQIk0WKGc= X-Gm-Gg: ATEYQzzPIdV1gJ5FHTj5t94Qk0uY+n4jeup0eldwYu4fV2y3nZWFh7+hixNCYhTzsTO Mv+GS4qhX/N5ni53ohhnB9VgegwE7xnov4MX28NLBVn/KCoDEPrpoyvU1/WHOqFf8Na3KRS2Uwp 7h4iTCqc8aTKknMTtUH/GMXlGxRkvXS0lTuKJLA873nViSi1jk1eURabNimSpSDgmL+mCTYvxh2 gDHRRC9nKaHGAc4U/SdBm3cuGfzwYY1Js/NlEw2OnkaooqUwjHlIHzaheLCTMoa1z4eQZTz46WW 0vYDFqWSnMpNnpTBq+ICCuagheNl1sHElJrbuA2xyQKyXBWH/xNAsvIlZHHObRTiRXE1d1qbmng 4cE8rN2UfC7+KlgX4CsRBjLVq8AKg2ddkUiF4SgC2fficNQ== X-Received: by 2002:a05:6300:95:b0:39b:8b59:4ec9 with SMTP id adf61e73a8af0-39c4a794ecamr4511566637.0.1774502152916; Wed, 25 Mar 2026 22:15:52 -0700 (PDT) X-Received: by 2002:a05:6300:95:b0:39b:8b59:4ec9 with SMTP id adf61e73a8af0-39c4a794ecamr4511539637.0.1774502152377; Wed, 25 Mar 2026 22:15:52 -0700 (PDT) Received: from [10.231.195.100] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d388f92sm1630877b3a.38.2026.03.25.22.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 22:15:51 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 13:15:44 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi To: Dmitry Baryshkov Cc: Jingyi Wang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com References: <20260322-knp-pmic-dt-v1-0-70bc40ea4428@oss.qualcomm.com> <20260322-knp-pmic-dt-v1-4-70bc40ea4428@oss.qualcomm.com> <13745334-c2dd-4a97-90de-a5ee18cff6a7@oss.qualcomm.com> <0279f334-95ed-4df8-9e42-749fd854c551@oss.qualcomm.com> <3xb6ya4zxhmaode3u3al5r4g3rfzlq2ifbyodvwtr3qgt34pwc@ia2xqfaeufd2> Content-Language: en-US From: Zijun Hu In-Reply-To: <3xb6ya4zxhmaode3u3al5r4g3rfzlq2ifbyodvwtr3qgt34pwc@ia2xqfaeufd2> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NOPYOk6g c=1 sm=1 tr=0 ts=69c4c109 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=1mDv_yBIlbhTikghve4A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: KiZ0QSR7kN7jPjUmREWSWJHr8sA68Ro2 X-Proofpoint-GUID: KiZ0QSR7kN7jPjUmREWSWJHr8sA68Ro2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDAzOCBTYWx0ZWRfX8uKxMVZKebMH azL98p1ebGHZQFpikmKEZhfBip/I7gL+npQ2D8GTlqRWl+Yci1tfgZcx8g70a9R1xsKADSF0ciJ NrzWRkmxCD09htm34ytfebLBi7ddztvnsqReZu/2VbDxTBgWWKWzQozvCk66qnsKFhh0LoRN/W1 LaQEmiSBhY3oSrSnBoa4itaL68svKMllbg/gM5Ss1yVNjexohK7mKvoNgKvBxnaOJAwSIB7vOhw yX0qZkVv+JDVfnk7kn4GmwQMd6UuMBDUsBoyeQ18HIR9lhyGRcNQXkXqMRH6TiN6wqZbgLFiYMu 0au0BB6+qTryexramoAJZuPj1VVLGmFWkfoCJUPfcnWhEONIdWtgDE/MgtPXZImPv1blXDDO7a4 NxpFgKffynW0mYnhHiHmpyaVE+DcGyoXoDbRX8pGJU2Fy7PtMhYweckTNsi1kHQJWj/mZAQmJMh 7Ljsff6XsIGGn9Ffujg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_01,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260038 On 3/26/2026 12:10 PM, Dmitry Baryshkov wrote: >> 3/25/2026 7:40 PM, Dmitry Baryshkov wrote: >>>> On 3/25/2026 3:08 PM, Dmitry Baryshkov wrote: >>>>> On Wed, Mar 25, 2026 at 02:40:19PM +0800, Zijun Hu wrote: >>>>>> On 3/24/2026 9:16 AM, Dmitry Baryshkov wrote: >>>>>>>> + >>>>>>>> + wcn7850-pmu { >>>>>>>> + compatible = "qcom,wcn7850-pmu"; >>>>>>>> + >>>>>>>> + pinctrl-0 = <&bt_default>, <&sw_ctrl_default>, <&wlan_en>; >>>>>>>> + pinctrl-names = "default"; >>>>>>>> + >>>>>>>> + bt-enable-gpios = <&pmh0104_j_e1_gpios 5 GPIO_ACTIVE_HIGH>; >>>>>>>> + wlan-enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; >>>>>>> swctrl-gpios? >>>>>> it is '<&sw_ctrl_default>' within 'pinctrl-0' above. >>>>>> the input pin is not used by power sequencing driver. >>>>>> just give it some default configurations here. >>>>> Please don't mix hardware description and the driver. If the pin is >>>>> wired, let's describe it in DT. >>>>> >>>> give comments about that pin in this dts file ? >>>> or give a seperated patch to describe the pin in DT binding schema of "qcom,wcn7850-pmu"? >>> It is there, as far as I remember. >>> >>> $ grep swctrl Documentation/devicetree/bindings/regulator/qcom,qca6390-pmu.yaml >>> swctrl-gpios: >> swctrl-gpios may be not applicable for 'qcom,wcn7850-pmu' since there is no 'qcom,wcn7850-pmu' node >> which configures 'swctrl-gpios' within upstream DT tree. > It's a wrong way to check it. > Instead follow these steps: > - Is the pin defined in the datasheet? datasheet define this pin SW_CTRL with description "Switch request to the external PMU between active and sleep mode" > - Is the pin defined in the schema? schema define property 'swctrl-gpios' with description "GPIO line indicating the state of the clock supply to the BT module" > - Is the pin wired in the hardware? pin SW_CTRL is wired in hardware. i have below confusions about 'swctrl-gpios' of 'qcom,wcn7850-pmu' which WCN7850 pin is 'swctrl-gpios' mean for ? Why to introduce 'swctrl-gpios' ? what problem does it solve ? how to solve the problem ?