mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Mosberger-Tang" <David.Mosberger@acm.org>
To: "Andrew Morton" <akpm@osdl.org>,
	"linux kernel" <linux-kernel@vger.kernel.org>
Subject: trivial videodev2.h patch
Date: Wed, 24 May 2006 22:14:13 -0600	[thread overview]
Message-ID: <ed5aea430605242114g1e51e7e9nb124de50dbbf1e40@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Hi Andrew,

linux/videodev2.h uses types such as __u8 but it fails to include
<linux/types.h>.  Within the kernel, that's not a problem because
<linux/time.h> already includes <linux/types.h>.  However, there are
user apps that try to include videodev2.h (e.g., ekiga) and at least
on ia64, it causes compilation failures since <linux/types.h> doesn't
get included for any other reason, leaving __u8 etc. undefined.  The
attached patch fixes the problem for me.

Thanks,

  --david
-- 
Mosberger Consulting LLC, http://www.mosberger-consulting.com/

[-- Attachment #2: videodev2.diff --]
[-- Type: text/x-patch, Size: 287 bytes --]

diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -19,6 +19,7 @@
 #include <linux/device.h>
 #include <linux/mutex.h>
 #endif
+#include <linux/types.h>
 #include <linux/compiler.h> /* need __user */
 
 

             reply	other threads:[~2006-05-25  4:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-25  4:14 David Mosberger-Tang [this message]
2006-05-25 10:03 ` Christian Kujau
2006-05-26 13:31   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed5aea430605242114g1e51e7e9nb124de50dbbf1e40@mail.gmail.com \
    --to=david.mosberger@acm.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®