From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202EBC433EF for ; Fri, 25 Feb 2022 01:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236604AbiBYBzM (ORCPT ); Thu, 24 Feb 2022 20:55:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236586AbiBYBzK (ORCPT ); Thu, 24 Feb 2022 20:55:10 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B9C29DD20 for ; Thu, 24 Feb 2022 17:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645754079; x=1677290079; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=mUtNdgA9eIG3EQUM/FNY38W2dgxVgh4wTcxODYjZ4f4=; b=hjsKuGRxGLhPkR2Fwu+0cetGFMq33SSViBPBLVFQfwWYqK01bbnqVmgL PyJWGM3nT9mdTSJ2NHgt9TuqJYhzlIQj5ECGtAf9fOAcuQt97hAwg/QZ9 eS19bwAVW/V5nqYmLd7v4oL8Eqzr1ut5oPEASuvFsMa4WMUdqidDXTjKj MFuEsdJMYWNjimK1fKG6qeVyR3WX4767l/fSeyAs2tC5HNjpIciPQm+X7 pxeUQbjwLiq/onEuj7/MlgTkl9mz+4Vzm9jRGQjwdCOQVBK4jasxzY7BE rfmG6VoCRlkMEBlAoV9ThboIxs7QwCJIrLk0qanKFpoCZy0z64gPbGmKg A==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="249978620" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="249978620" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 17:54:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533385060" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga007.jf.intel.com with ESMTP; 24 Feb 2022 17:54:35 -0800 Message-ID: Date: Fri, 25 Feb 2022 09:53:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Kevin Tian , Ashok Raj , Liu Yi L , Jacob Pan , Robin Murphy , Christoph Hellwig , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/11] iommu/vt-d: Remove commented code Content-Language: en-US To: Jason Gunthorpe References: <20220214025704.3184654-1-baolu.lu@linux.intel.com> <20220214025704.3184654-10-baolu.lu@linux.intel.com> <20220224130945.GL6413@nvidia.com> From: Lu Baolu In-Reply-To: <20220224130945.GL6413@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/22 9:09 PM, Jason Gunthorpe wrote: > On Mon, Feb 14, 2022 at 10:57:02AM +0800, Lu Baolu wrote: >> This removes unnecessary commented code. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/iommu/intel/iommu.c | 10 +--------- >> 1 file changed, 1 insertion(+), 9 deletions(-) > > Assuming you don't want to uncomment it I planned to postpone the decision as I need time to check the details in the VT-d spec and talk to the architecture experts if needed. > > Reviewed-by: Jason Gunthorpe > > Jason Best regards, baolu