From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
John Oldman <john.oldman@polehill.co.uk>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements
Date: Mon, 27 Apr 2020 10:14:28 -0700 [thread overview]
Message-ID: <ed61ea55a275e520e6245c9fe33f2f076d5cbe3c.camel@perches.com> (raw)
In-Reply-To: <20200427160430.GA3549342@kroah.com>
On Mon, 2020-04-27 at 18:04 +0200, Greg KH wrote:
> On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote:
> > Make a better job of fixing coding style issues, this time fixing
> > all blocks as per Joe Perches' comment.
[]
> Why is this not just one patch?
Hi John.
These _should_ be one patch.
The subject line should be versioned and affirmative like:
Subject: [PATCH V2] staging: rts5208: rtsx: Use balanced braces for if/else if blocks
The subject should not include "fix", as this is a coding style
issue and not really a logical defect.
Lastly the "this time fixing" bit should be below the --- line.
cheers, Joe
prev parent reply other threads:[~2020-04-27 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:24 [PATCH 1/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue John Oldman
2020-04-27 15:24 ` [PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements John Oldman
2020-04-27 16:04 ` Greg KH
2020-04-27 17:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed61ea55a275e520e6245c9fe33f2f076d5cbe3c.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.oldman@polehill.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®