From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427094AbdDVAaQ (ORCPT ); Fri, 21 Apr 2017 20:30:16 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:5450 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162674AbdDVAaO (ORCPT ); Fri, 21 Apr 2017 20:30:14 -0400 Subject: Re: [PATCH 1/2] f2fs: add braces for macro variables more To: Jaegeuk Kim , , , References: <20170421004957.23760-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Sat, 22 Apr 2017 08:30:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170421004957.23760-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.58FAA40F.003C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8c3de0a0964704272821fc2d4086e066 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/4/21 8:49, Jaegeuk Kim wrote: > This patch adds braces for macro variables more in include/linux/f2fs_fs.h. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h | 1 + > include/linux/f2fs_fs.h | 10 +++++----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index e2d9a8d9101e..ca647d264b61 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include This is no needed. ;) Thanks, > #include > #include > #include > diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h > index e2d239ed4c60..639cbdf65e2b 100644 > --- a/include/linux/f2fs_fs.h > +++ b/include/linux/f2fs_fs.h > @@ -32,9 +32,9 @@ > /* 0, 1(node nid), 2(meta nid) are reserved node id */ > #define F2FS_RESERVED_NODE_NUM 3 > > -#define F2FS_ROOT_INO(sbi) (sbi->root_ino_num) > -#define F2FS_NODE_INO(sbi) (sbi->node_ino_num) > -#define F2FS_META_INO(sbi) (sbi->meta_ino_num) > +#define F2FS_ROOT_INO(sbi) ((sbi)->root_ino_num) > +#define F2FS_NODE_INO(sbi) ((sbi)->node_ino_num) > +#define F2FS_META_INO(sbi) ((sbi)->meta_ino_num) > > #define F2FS_IO_SIZE(sbi) (1 << (sbi)->write_io_size_bits) /* Blocks */ > #define F2FS_IO_SIZE_KB(sbi) (1 << ((sbi)->write_io_size_bits + 2)) /* KB */ > @@ -161,7 +161,7 @@ struct f2fs_checkpoint { > */ > #define F2FS_ORPHANS_PER_BLOCK 1020 > > -#define GET_ORPHAN_BLOCKS(n) ((n + F2FS_ORPHANS_PER_BLOCK - 1) / \ > +#define GET_ORPHAN_BLOCKS(n) (((n) + F2FS_ORPHANS_PER_BLOCK - 1) / \ > F2FS_ORPHANS_PER_BLOCK) > > struct f2fs_orphan_block { > @@ -449,7 +449,7 @@ typedef __le32 f2fs_hash_t; > #define F2FS_SLOT_LEN 8 > #define F2FS_SLOT_LEN_BITS 3 > > -#define GET_DENTRY_SLOTS(x) ((x + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS) > +#define GET_DENTRY_SLOTS(x) (((x) + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS) > > /* MAX level for dir lookup */ > #define MAX_DIR_HASH_DEPTH 63 >