From: Dexuan Cui <decui@microsoft.com>
To: KY Srinivasan <kys@microsoft.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>
Cc: KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe
Date: Fri, 17 Jul 2015 10:07:03 +0000 [thread overview]
Message-ID: <ed6433db194c4f2393cc462b538d9b2f@SIXPR30MB031.064d.mgd.msft.net> (raw)
In-Reply-To: <1437074222-13020-1-git-send-email-kys@microsoft.com>
> From: K. Y. Srinivasan
> Sent: Friday, July 17, 2015 3:17
> Subject: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed
> during probe
>
> The current code returns from probe without waiting for the proper handling
> of subchannels that may be requested. If the netvsc driver were to be rapidly
> loaded/unloaded, we can trigger a panic as the unload will be tearing
> down state that may not have been fully setup yet. We fix this issue by making
> sure that we return from the probe call only after ensuring that the
> sub-channel offers in flight are properly handled.
>
> ---
> drivers/net/hyperv/hyperv_net.h | 2 ++
> drivers/net/hyperv/rndis_filter.c | 25 +++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 0 deletions(-)
BTW, not sure if we should make the same fix to storvsc.
IMO storvsc should have the same issue, at least in theory, though usually it's
unlikely to unload storvsc. :-)
Thanks,
-- Dexuan
next prev parent reply other threads:[~2015-07-17 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 19:17 K. Y. Srinivasan
2015-07-17 10:00 ` Dexuan Cui
2015-07-17 15:33 ` KY Srinivasan
2015-07-20 9:39 ` Dexuan Cui
2015-07-20 19:00 ` KY Srinivasan
2015-07-17 10:07 ` Dexuan Cui [this message]
2015-07-17 15:34 ` KY Srinivasan
2015-07-17 14:12 ` Vitaly Kuznetsov
2015-07-17 15:53 ` KY Srinivasan
2015-07-17 16:09 ` Vitaly Kuznetsov
2015-07-17 16:13 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6433db194c4f2393cc462b538d9b2f@SIXPR30MB031.064d.mgd.msft.net \
--to=decui@microsoft.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®