From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 324052EEE79 for ; Tue, 4 Aug 2026 03:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785814731; cv=none; b=FOc5ljEReLwgulrWpDx38CQdTHj/eu5/cCJAVx5fUw4LHh6wvPJRQ5qo/E+Ou7bhTWQlM1fIn72nJx/SV34xdfLrFdxH+OG+gGHOXfhnVLbqBdpxn00my5HieyzAzoThGXxy8OweBf+eI/B2V+pNcW23pPqpvCP5vXA5Br4L2Bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785814731; c=relaxed/simple; bh=H5pvd+eUzMQaPVwBbnrRs3I0P4w75Sabwf00JMs5UKw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ejQ1Z4n5x1TzVnanHoChKf4ClbFrQTWm85pdZdU/YJ2J2NH+pjcSCXgCSMYPw/kFCtrVYbeC2rVjzRzARLohpaPquJGTWxO45Al0FS4YeOjEQ0Yx+Qq7Uv4RgpeGFU3Rz4FiEI5fo9YP+TPSAWip34aQlplMn7m6Jlbuy5mM1Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g9tTyMcG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AS5sqaIK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g9tTyMcG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AS5sqaIK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785814729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wNvmfBcFcCTIC1AY1WFodqG2nUyiP6xrqhsC69kDaxg=; b=g9tTyMcG8GR6w9mlTWe8H64/DTOOxw4LFu100ID0XtPuEK8b/82ps18d6p9HQhEoFd0MLG zsqzWHFRZC4x63eap/1JWeiraNqgAsQqT13JvZtsvw+IZ1WhpAR69JcUWKQQOuuWStq6D5 OpjHlP01U8IuvjLGh6Y/T+G4mHZUuZg= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-fUhzqblUNeWDWmnU213knw-1; Mon, 03 Aug 2026 23:38:42 -0400 X-MC-Unique: fUhzqblUNeWDWmnU213knw-1 X-Mimecast-MFC-AGG-ID: fUhzqblUNeWDWmnU213knw_1785814721 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb6cf425e86so5206799a12.1 for ; Mon, 03 Aug 2026 20:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785814721; x=1786419521; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wNvmfBcFcCTIC1AY1WFodqG2nUyiP6xrqhsC69kDaxg=; b=AS5sqaIKiTScFszdrstO69bIhZJ5gzzn5h4IIV7lQbM7SfsgrWgy/MeTI7vsUyP4gi CilMqWhSNcAa6AOJhIjBGRR2oiNrYpTN/cMcRhEY4YYpdMbwGw4BBfGdbkTFhW3c9TF+ DX7GYNfbAzgE7XxICCwq6B8ojy9uJxkRIQ8azMO1NKWW1rAegHCt5kR+ipVEw+fPTOdA LB791Skanz+4Pg4xpYdoTJlS/tg+QhDNM+40CDOYc9Gv648nd9eQRy64gqksrvQ4tkDC 9F+i7sPXXqaBuQ6NQggzsphVVf4QTaAb4YKBPy8U1culSW84Ly5UQuKubU/KDozQHINA mY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785814721; x=1786419521; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wNvmfBcFcCTIC1AY1WFodqG2nUyiP6xrqhsC69kDaxg=; b=HCsKSlGkOObPVxyiSM6pPJrXmVZxytHwt2MRudpeS8d7pPTLY5ZuZg+kxR8+t7VgZm 9j8tPn/teA1aHbJEyFo255+3m9utzp7tROsomwEeCu/yENVdbGJH/1PJL1RFuERAsgJL G1o6fC0YTF/KuI6YWkagBybkpukstJl12WIfSIh++siFluDo1kNPKn4OhUCNwKWcOa2N 8Enykx4k6r3MkGLS1zEu/+qFm28G+m5HTosh2GWfwZ/5jqrg1l4DtH6LclsoJbyYPElr ZbUA+lnslSN4a+3fb3V+wjT6WbuZ67idTmjVCxmnwch2smt/wuswCjR2mG/YnJrPksKG Ppjw== X-Forwarded-Encrypted: i=1; AHgh+RpI2GcAFkqY/FU4HzFw1Zv8zc9/BJ1f16XqYCCD5SKYh3Eug5egI1YBd4xA4pcQCKgFpFOMELemze0qy6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+z+vHfq8QSfTEUDBYh3wg9iN8ngdCRSbUneeJBfE33gRMbSrP /Fkz3Q9b+tyZ7hxf3tlIsw3WYNb6cZIBYofTu0nj5GnNnN/UwJMZbgYYq1hXfBTZFgKO1/25VdF wdO/zwid5ttu+3kRQHqLcuJxz3/ojgT/E7PD5z5w55pS7G2mYD6gmnpUOscNCT7skpw== X-Gm-Gg: AR+sD12z5fyBSUfTQfE87Gd36MARDMaSGo08Zws66koqgK8VvPDKCAsUG9G5Zy2V0kD ew89CRBExbR1kmRQEH5px7it9D8b3CJcO7BfeT8uhYIqYQMWy+w5kwJcy5IpYEFt8iGFo4QtK1b dV0Klxtz6zmDSDoxQwIzZmr2lwhFRFPDEPBT1jzqbZfXf9i50JpyZYhXVdpuSocjD8+SGjZv9f1 skgl28fKFwEOyBh6LAsOspZvtisSHnfDS7vdiWYgmk7qq3mupujfv6vFgeR4B9jivrcytq871d1 2KgYFPmWluC0BjlJSYaOCRYL6doBgGd7rOI0NrVV/9nUt2RrpirYNqaDAtSwaJEBH98SmsAwrAJ XGT79RkIj77NjjFSqDh4BKVl+Jq/e3+uS3fVx9IjHyjA= X-Received: by 2002:a05:6a20:914a:b0:3c1:b9c:4890 with SMTP id adf61e73a8af0-3c92a5d7954mr12778827637.22.1785814721041; Mon, 03 Aug 2026 20:38:41 -0700 (PDT) X-Received: by 2002:a05:6a20:914a:b0:3c1:b9c:4890 with SMTP id adf61e73a8af0-3c92a5d7954mr12778808637.22.1785814720635; Mon, 03 Aug 2026 20:38:40 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab143a7csm33178004c88.4.2026.08.03.20.38.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 20:38:40 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 13:38:30 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/11] arm_mpam: let low level MSC accessors return an error To: Andre Przywara , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260731170324.2927758-1-andre.przywara@arm.com> <20260731170324.2927758-2-andre.przywara@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260731170324.2927758-2-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/1/26 3:03 AM, Andre Przywara wrote: > The upcoming MPAM-Fb support does not use MMIO primitives to access an > MSC, but employs a shared-memory/doorbell based firmware protocol. > Its complexity means that it must be able to handle errors, whereas we > always assume an MMIO based MSC access succeeds today. > > Change the __mpam_read_reg() low level accessor function to return the > requested data through a pointer, and return an error code instead. > Also change the __mpam_write_reg() accessor function to return an error > code. At the moment this is always 0, so all error handling paths are > not exercised at the moment. This will change later when alternative > MSC access methods like MPAM-Fb are activated. > > Change all direct users of those MSC wrappers to comply with the new > prototypes, though the errors are not propagated all the way up yet. > > Signed-off-by: Andre Przywara > Reviewed-by: Jonathan Cameron > Reviewed-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 208 +++++++++++++++++++++------------ > 1 file changed, 134 insertions(+), 74 deletions(-) > Reviewed-by: Gavin Shan