From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbdCAG0R (ORCPT ); Wed, 1 Mar 2017 01:26:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:40979 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbdCAG0P (ORCPT ); Wed, 1 Mar 2017 01:26:15 -0500 Subject: Re: [Xen-devel] [PATCH 3/5] x86/xen: put setup.c, mmu.c and p2m.c under CONFIG_XEN_PV To: Vitaly Kuznetsov , xen-devel@lists.xenproject.org References: <20170224161440.2136-1-vkuznets@redhat.com> <20170224161440.2136-4-vkuznets@redhat.com> Cc: Boris Ostrovsky , x86@kernel.org, Andrew Jones , linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: Date: Wed, 1 Mar 2017 07:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170224161440.2136-4-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/17 17:14, Vitaly Kuznetsov wrote: > These three files (mmu.c, p2m.c, setup.c) are mostly required to support > PV guests, in fact p2m.c and setup.c have no code for PVHVM at all. mmu.c > has some, split the file into mmu.c, mmu_pv.c and mmu_hvm.c. > > Some additional changes are required: > - In the balloon driver we can't use xen_start_info, xen_released_pages > and xen_extra_mem it is PV-only. Decorate it with #ifdef CONFIG_XEN_PV > > - Some PV-only functions are used by drivers and for PVHVM guests these > functions have 'if (xen_feature(XENFEAT_auto_translated_physmap))' check > in the beginning. Create required stubs for PVHVM-only builds. > > Signed-off-by: Vitaly Kuznetsov And again: split the patch up, please. Juergen