From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, soc@kernel.org,
"Stephen Boyd" <sboyd@kernel.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Luo Jie" <quic_luoj@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Jagadeesh Kona" <quic_jkona@quicinc.com>
Subject: Re: [GIT PULL 2/4] soc: dt updates for 6.11
Date: Tue, 16 Jul 2024 21:33:42 +0200 [thread overview]
Message-ID: <ed757bc4-38ba-420a-9da8-d7de1f1123f6@app.fastmail.com> (raw)
In-Reply-To: <CAHk-=whp2O+NjOXf77hfATgEe-LHTefbFb0eR=ytQUJTOUnfdQ@mail.gmail.com>
On Tue, Jul 16, 2024, at 20:55, Linus Torvalds wrote:
> On Mon, 15 Jul 2024 at 14:03, Arnd Bergmann <arnd@arndb.de> wrote:
> And no, this is not some kind of merge mistake of mine. It was wrong
> in your tree.
>
> qcom_cc_really_probe() has always taken a
>
> struct platform_device *pdev
>
> as the first argument, not a "struct device *". So the "&pdev->dev"
> thing is completely wrong, and always has been.
>
> Looking around, this was also reported by the kernel test robot at
>
> https://lore.kernel.org/all/202407072331.baglL4Sd-lkp@intel.com/
> https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@intel.com/
>
> and still I had to just notice it in my local build test.
>
> I did fix it up, but this is *not* ok.
I'm very sorry about this. I had missed the extra driver slipping
in with the qcom DT patches at first and then failed to build test
the dt branch standalone even after I realized it was there.
I see that the interface change is in
git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git#clk-next,
which also contains the commit with the driver. This means you'll
probably have to revert your fix once you merge that branch.
Apparently the new driver was tested by the authors based on the
other changes that are in the clk tree, but committed on a branch
that didn't have them.
Arnd
next prev parent reply other threads:[~2024-07-16 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 21:03 [GIT PULL 0/4] soc tree " Arnd Bergmann
2024-07-15 21:05 ` [GIT PULL 1/4] soc: driver updates " Arnd Bergmann
2024-07-16 19:25 ` pr-tracker-bot
2024-07-16 19:53 ` Linus Torvalds
2024-07-16 20:15 ` Bartosz Golaszewski
2024-07-16 20:34 ` Linus Torvalds
2024-07-16 20:49 ` Bartosz Golaszewski
2024-07-15 21:10 ` [GIT PULL 2/4] soc: dt " Arnd Bergmann
2024-07-16 18:55 ` Linus Torvalds
2024-07-16 19:33 ` Arnd Bergmann [this message]
2024-07-16 19:25 ` pr-tracker-bot
2024-07-15 21:11 ` [GIT PULL 3/4] soc: defconfig " Arnd Bergmann
2024-07-16 19:25 ` pr-tracker-bot
2024-07-15 21:12 ` [GIT PULL 4/4] soc: arm platform " Arnd Bergmann
2024-07-16 19:25 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed757bc4-38ba-420a-9da8-d7de1f1123f6@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jkona@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®