mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Vidya Sagar <vidyas@nvidia.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] arm64: tegra: Fix PCIe regulator for Orin Jetson AGX
Date: Tue, 30 May 2023 12:22:54 +0100	[thread overview]
Message-ID: <ed797fc9-98de-bcc0-583c-6b1c4a807204@nvidia.com> (raw)
In-Reply-To: <6dd9edcb-40cf-9873-b8aa-993bb18a3584@nvidia.com>



On 26/05/2023 12:19, Jon Hunter wrote:
> Adding linux-tegra ...
> 
> On 26/05/2023 12:17, Jon Hunter wrote:
>> The PCIe slot on the Jetson Orin AGX is not working and PCIe cards
>> are not detected. The regulator for the 3.3V regulator for the PCIe is
>> using the wrong GPIO for turning on the regulator. Fix this by updating
>> the 3.3V regulator to use the correct GPIO.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi 
>> b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> index e161618cfca8..4dce2e214002 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> @@ -142,7 +142,7 @@ vdd_3v3_pcie: regulator-vdd-3v3-pcie {
>>           regulator-name = "VDD_3V3_PCIE";
>>           regulator-min-microvolt = <3300000>;
>>           regulator-max-microvolt = <3300000>;
>> -        gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
>> +        gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;


Apparently the original GPIO we had was for pre-production boards and 
hence the mistake was made. Let me know if you want me to add that 
detail to the commit message.

Jon

-- 
nvpublic

  reply	other threads:[~2023-05-30 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 11:17 Jon Hunter
2023-05-26 11:19 ` Jon Hunter
2023-05-30 11:22   ` Jon Hunter [this message]
2023-05-26 15:07 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed797fc9-98de-bcc0-583c-6b1c4a807204@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®