From: linmiaohe <linmiaohe@huawei.com>
To: John Hubbard <jhubbard@nvidia.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"richardw.yang@linux.intel.com" <richardw.yang@linux.intel.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
"jannh@google.com" <jannh@google.com>,
"steve.capper@arm.com" <steve.capper@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"walken@google.com" <walken@google.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"tiny.windzz@gmail.com" <tiny.windzz@gmail.com>,
"david@redhat.com" <david@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm: get rid of odd jump labels in find_mergeable_anon_vma()
Date: Mon, 18 Nov 2019 06:24:42 +0000 [thread overview]
Message-ID: <ed7a8b5fb71d4ff4b7b515f402aa265a@huawei.com> (raw)
John Hubbard wrote:
> On 11/17/19 7:22 PM, linmiaohe wrote:
> > From: Miaohe Lin <linmiaohe@huawei.com>
> >
> > The jump labels try_prev and none are not really needed in
> > find_mergeable_anon_vma(), eliminate them to improve readability.
> > -v2:
> > Fix commit descriptions and further simplify the code
> > as suggested by David Hildenbrand and John Hubbard.
>
> Admin point: the above three lines will end up in the commit log, which is probably not what you intended. If, instead, you put them below the "---" line, then they will act as comments about the patch, and won't show up in the commit log.
>
>
Thanks for your remind. I'am sorry for this mistake. I'll fix this. Many thanks.
next reply other threads:[~2019-11-18 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 6:24 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-18 3:22 linmiaohe
2019-11-18 3:31 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7a8b5fb71d4ff4b7b515f402aa265a@huawei.com \
--to=linmiaohe@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=steve.capper@arm.com \
--cc=tiny.windzz@gmail.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome