From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A523C433E0 for ; Mon, 18 Jan 2021 19:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31E2620715 for ; Mon, 18 Jan 2021 19:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437032AbhARTGB (ORCPT ); Mon, 18 Jan 2021 14:06:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:42384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407913AbhARTEb (ORCPT ); Mon, 18 Jan 2021 14:04:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5547720756; Mon, 18 Jan 2021 19:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610996631; bh=n6ZqPSvHwOtagI+O+dxOJ2Lau8vm7rGXzdL32UD9bbI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HK6YJfEucQ7G+/yLCb02/WXEJhblwMXqa6LsyYTuIDOtHzOhThANjlv/GGeHV8aQg Yc4/o9DKCyBru3zWVi27k+ZwA3na+OtXFnTuj440ssHH0RisJkifDQIwQgiIhIqMcX ryUkUbc7dfk/paSGCMbx4ntr/iHhSnMJ8muT4bcRwqRcpuF70GnNo7i+p1TtHNnqev HIi+QwttdyYrqBv+W3909lcRVyeHGK3G5ERZcdW8IgayfAm59Ivy/CuqHrSimOX8iX kguRqly4dYhqVvVT+1Nigqpob6nCOOiHf0uPiLlT5c34UZAEjTEGxyJpmHXDt+H2Om vc/Em01BazbJg== Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps To: Matthew Wilcox Cc: Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Sergey Senozhatsky , Petr Mladek , roman.fietze@magna.com, keescook@chromium.org, Steven Rostedt , John Ogness , linux-mm@kvack.org, Akinobu Mita References: <20210116220950.47078-1-timur@kernel.org> <20210118182635.GD2260413@casper.infradead.org> From: Timur Tabi Message-ID: Date: Mon, 18 Jan 2021 13:03:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210118182635.GD2260413@casper.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/18/21 12:26 PM, Matthew Wilcox wrote: > Don't make it easy. And don't make it look like they're doing > something innocent. DUMP_PREFIX_SECURITY_HOLE would be OK > by me. DUMP_PREFIX_LEAK_INFORMATION would work fine too. > DUMP_PREFIX_MAKE_ATTACKERS_LIFE_EASY might be a bit too far. It's already extremely easy to replace %p with %px in your own printks, so I don't really understand your argument. Seriously, this patch should not be so contentious. If you want hashed addresses, then nothing changes. If you need unhashed addresses while debugging, then use DUMP_PREFIX_UNHASHED. Just like you can use %px in printk. I never use %p in my printks, but then I never submit code upstream that prints addresses, hashed or unhashed.