From: Mark Brown <broonie@kernel.org>
To: Baojun Xu <baojun.xu@ti.com>
Cc: tiwai@suse.de, andriy.shevchenko@linux.intel.com,
13916275206@139.com, alsa-devel@alsa-project.org,
shenghao-ding@ti.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, k-yi@ti.com, henry.lo@ti.com,
robinchen@ti.com, niranjan.hy@ti.com, pin-hao.huang@hp.com,
Syed.SabaKareem@amd.com
Subject: Re: [PATCH v4] ASoC: tas2783-sdw: add firmware download status check
Date: Tue, 15 Sep 2026 19:53:28 +0100 [thread overview]
Message-ID: <ed7fd58d-e36d-4d40-afda-fb9937ed1e5f@sirena.org.uk> (raw)
In-Reply-To: <20260915035223.1518-1-baojun.xu@ti.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
On Tue, Sep 15, 2026 at 11:52:23AM +0800, Baojun Xu wrote:
> Currently, the firmware download is unnecessarily triggered on every
> system resume from suspend, causing significant wake-up latency. However,
> this step is redundant if the AMP remains powered on.
> - tas_dev->fw_dl_success = false;
> + regmap_read(tas_dev->regmap, TASDEV_REG_SDW(0, 0, 7), &val);
> + /* Check if the AMP is in reset status. */
> + if (val == 0x20) {
> + tas_dev->fw_dl_success = false;
Don't we also need to set the flag to true if we're skipping download,
what'll happen if we get here if the firmware was downloaded prior to
the driver starting (eg, you can probably trigger that with a bind/unbind)?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-15 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 3:52 Baojun Xu
2026-09-15 18:53 ` Mark Brown [this message]
2026-09-15 19:06 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7fd58d-e36d-4d40-afda-fb9937ed1e5f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=13916275206@139.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=henry.lo@ti.com \
--cc=k-yi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=pin-hao.huang@hp.com \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®