From: "Timur Tabi" <timur@freescale.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Haavard Skinnemoen" <haavard.skinnemoen@atmel.com>
Subject: Re: dmaengine.c: question about device_alloc_chan_resources
Date: Thu, 18 Sep 2008 09:13:56 -0500 [thread overview]
Message-ID: <ed82fe3e0809180713v7e7a6115ya4612aa68879e39d@mail.gmail.com> (raw)
In-Reply-To: <e9c3a7c20809171536i189e3816x8572055d932c3c4c@mail.gmail.com>
On Wed, Sep 17, 2008 at 5:36 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> I believe the problem is that dmatest is telling the core to take
> multiple references on a channel. Take a look at
> net/core/dev.c:netdev_dma_event and
> crypto:asynx_tx/async_tx.c:dma_channel_add_remove both of those check
> to see if they already have a refence to the channel.
Ok, I see what these functions are doing, and dmatest_add_channel() is
not doing it. dmatest_add_channel() should not assume that it will
only receive one and only one DMA_RESOURCE_AVAILABLE for each channel.
I'll post a patch, if Haavard doesn't do it first. Thanks for looking
into this and getting back to me. I've spent the entire week
debugging this.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-09-18 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 21:30 Timur Tabi
2008-09-17 22:36 ` Dan Williams
2008-09-18 14:13 ` Timur Tabi [this message]
2008-09-18 14:28 ` Haavard Skinnemoen
2008-09-18 14:31 ` Timur Tabi
2008-09-18 14:45 ` Haavard Skinnemoen
2008-09-18 14:49 ` Timur Tabi
2008-09-18 15:00 ` Haavard Skinnemoen
2008-09-19 4:20 ` Dan Williams
2008-09-19 11:25 ` Haavard Skinnemoen
2008-09-19 14:34 ` Timur Tabi
2008-09-19 14:50 ` linux-os (Dick Johnson)
2008-09-19 15:01 ` Timur Tabi
2008-09-19 15:28 ` Alan Cox
2008-09-20 23:00 ` Dan Williams
2008-09-21 9:26 ` Haavard Skinnemoen
2008-09-21 19:50 ` Guennadi Liakhovetski
2008-09-22 7:44 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed82fe3e0809180713v7e7a6115ya4612aa68879e39d@mail.gmail.com \
--to=timur@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®