From: Mark Brown <broonie@kernel.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Li Ningke <lnk_01@hust.edu.cn>,
hust-os-kernel-patches@googlegroups.com,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`
Date: Mon, 24 Apr 2023 16:52:25 +0100 [thread overview]
Message-ID: <ed846afc-7155-4998-9a8d-e9d9e8aaf8e2@sirena.org.uk> (raw)
In-Reply-To: <46299274-d827-279f-cadf-020e93296c13@hust.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Mon, Apr 24, 2023 at 08:03:42PM +0800, Dongliang Mu wrote:
> On 2023/4/24 19:48, Mark Brown wrote:
> > Is that check valid? 0 was a valid interrupt for some architectures...
> We just follow the comments of platform_get_irq().
> * Gets an IRQ for a platform device and prints an error message if finding
> the
> * IRQ fails. Device drivers should check the return value for errors so as
> to
> * not pass a negative integer value to the request_irq() APIs.
I'm not sure that's universally true yet, though there were some moves
to try to get us there. arm, where this driver is used, was one of the
platforms with 0 as a valid interrupt.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-24 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 3:24 Li Ningke
2023-04-24 11:48 ` Mark Brown
2023-04-24 12:03 ` Dongliang Mu
2023-04-24 15:52 ` Mark Brown [this message]
2023-04-26 1:50 ` Dongliang Mu
2023-04-26 14:13 ` Mark Brown
2023-04-26 15:07 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed846afc-7155-4998-9a8d-e9d9e8aaf8e2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dzm91@hust.edu.cn \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lnk_01@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®