From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C98266B54 for ; Wed, 23 Apr 2025 06:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745389298; cv=none; b=YigAd87B3VB5Nudm1HtfEqct0zHH18+4MrkACjdIWoDJPArPmbOXVJ1ui12ojGU3uVqkzleQSqjNXI9d3JSIzeVE4oOpOuZm37l2ajYz7xbMjlKeIT3hmO/48Ko1kzGTJPdaFJRPwNZILHQXI11KHgYe+3TPGlw10JNoQIdFt84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745389298; c=relaxed/simple; bh=1AsZC11S/vL8wq95waCVQUPjNElu5Zm0Tm6OXx7SlLs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qv0ix6hyFnUuJQJJl8YS9XqndxowTF5nSe5TI+HtkbCDmKoXo2IdjH2ek9P9FEp6uT+xSXEo6tQFPbgpeqemF6m8tWuTHbdsvlts6naARRc5ybhHq+U5Nu3o81C+TUT7twbTn17AEMM9nTvVS0R/fiS+MEZ0AJCdqPbw3LqN+l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=X7Tb+4sc; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8ah17k4t; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iBMizeFU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=/43G+4pW; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="X7Tb+4sc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8ah17k4t"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iBMizeFU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/43G+4pW" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBC23211AC; Wed, 23 Apr 2025 06:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745389295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VPilbHRhk/K5ZBOCPJOvfextA3nm+QGqvwc1ZzV5TM=; b=X7Tb+4sc7oYXND0gqmrAIbZJesKIuL30YKbKYHRx+y12CsFOeB9+TVa/GLRwIyhcbbD78o 6Hti29YjdZNfDFD9Cr+j5+OwhiibXqDjPfaViuWXzFXR3YMl821pknaLuqbV259NR0BJ53 37zj55ZTLuUhDdp1zVuxQozN/3UoTRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745389295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VPilbHRhk/K5ZBOCPJOvfextA3nm+QGqvwc1ZzV5TM=; b=8ah17k4tlHNGLNyFsInWpEMI06n1G/oYmvYHOQ73tFJVOEzvbbbTNbuufkVhzoi1m4litV CGX5muDiEH5K61Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iBMizeFU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/43G+4pW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745389294; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VPilbHRhk/K5ZBOCPJOvfextA3nm+QGqvwc1ZzV5TM=; b=iBMizeFUGVmXg3/TYWINQZTpv1Vm+4mUS6BZepdRTDLs+WAZ+VcBeZCC4sVt2j96u7eXKK ageVRzjrXZB+bWOrdoiR/CwFsxW6GDRcTHC9PcGJSXL0WhBYEhOgJhZyvnL2fNXJ0g6Xa8 dDs7kzqx7RgDXzP8yiyFaqCtc+073Ps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745389294; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VPilbHRhk/K5ZBOCPJOvfextA3nm+QGqvwc1ZzV5TM=; b=/43G+4pWMt7toMjzbn4SdHmsBSPj+7t3F8HAu1PnEI5uLu1JOuQWi+pvHqhfyQhKVHQtZS 50olcOPJd/CyOBBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8683C13691; Wed, 23 Apr 2025 06:21:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fY6rHu6GCGisUQAAD6G6ig (envelope-from ); Wed, 23 Apr 2025 06:21:34 +0000 Message-ID: Date: Wed, 23 Apr 2025 08:21:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmet-tcp: don't restore null sk_state_change To: Alistair Francis , hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, csander@purestorage.com, shinichiro.kawasaki@wdc.com, Alistair Francis References: <20250423060621.632581-1-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250423060621.632581-1-alistair.francis@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EBC23211AC X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[gmail.com,lst.de,grimberg.me,nvidia.com,lists.infradead.org]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 4/23/25 08:06, Alistair Francis wrote: > queue->state_change is set as part of nvmet_tcp_set_queue_sock(), but if > the TCP connection isn't established when nvmet_tcp_set_queue_sock() is > called then queue->state_change isn't set and sock->sk->sk_state_change > isn't replaced. > > As such we don't need to restore sock->sk->sk_state_change if > queue->state_change is NULL. > Good catch! [ .. ] > Resolves: https://lore.kernel.org/linux-nvme/5hdonndzoqa265oq3bj6iarwtfk5dewxxjtbjvn5uqnwclpwt6@a2n6w3taxxex/ > Signed-off-by: Alistair Francis > --- > We could also remove the `sock->sk->sk_state != TCP_ESTABLISHED` check > in nvmet_tcp_set_queue_sock() if that's prefered. > Please do. We cannot influence what the network stack did, so if there ever were a modification which caused the ->state_change callback _not_ to be set the whole issue pops up again. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich