From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ling Xu <quic_lxu5@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: quic_kuiw@quicinc.com, quic_ekangupt@quicinc.com,
kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Aiqun Yu (Maria)" <quic_aiquny@quicinc.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property
Date: Mon, 12 Feb 2024 12:41:16 +0100 [thread overview]
Message-ID: <ed9bf914-8b3e-401e-93c0-77eae97e2ab8@linaro.org> (raw)
In-Reply-To: <7edfed88-d84f-41e1-8c10-4af6efe53c4c@quicinc.com>
On 12/02/2024 12:31, Ling Xu wrote:
> 在 2024/2/12 19:10, Krzysztof Kozlowski 写道:
>> On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
>>> On 25/01/2024 11:24, Ling Xu wrote:
>>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>>> maintained during DMA operations.
>>>>
>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
>>>
>>> This wasn't ever tested:
>>>
>>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
>>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>
>>> Ling,
>>> How is this testing-patches-before-sending work in different teams? Do
>>> you have such requirement?
>>
>> No clue if the original DTS change should be reverted or these are in
>> fact DMA coherent, but let's choose one path...
>>
>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
I don't understand your comment. Did you read the link above?
Anyway, I was asking: are you testing the patches before sending?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-12 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 10:24 [PATCH 0/2] arm64: dts: qcom: Add dma-coherent property on Ling Xu
2024-01-25 10:24 ` [PATCH 1/2] arm64: dts: qcom: sm8550: Add dma-coherent property Ling Xu
2024-01-25 16:38 ` Konrad Dybcio
2024-01-26 2:34 ` Ling Xu
2024-02-01 20:39 ` Konrad Dybcio
2024-01-25 10:24 ` [PATCH 2/2] arm64: dts: qcom: sm8650: " Ling Xu
2024-02-12 11:00 ` Krzysztof Kozlowski
2024-02-12 11:10 ` Krzysztof Kozlowski
2024-02-12 11:31 ` Ling Xu
2024-02-12 11:41 ` Krzysztof Kozlowski [this message]
2024-02-12 11:45 ` Ling Xu
2024-02-12 11:48 ` Krzysztof Kozlowski
2024-02-07 4:46 ` [PATCH 0/2] arm64: dts: qcom: Add dma-coherent property on Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9bf914-8b3e-401e-93c0-77eae97e2ab8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_ekangupt@quicinc.com \
--cc=quic_kuiw@quicinc.com \
--cc=quic_lxu5@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®