From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761556AbdEVT3R (ORCPT ); Mon, 22 May 2017 15:29:17 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35552 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756486AbdEVT3P (ORCPT ); Mon, 22 May 2017 15:29:15 -0400 Subject: Re: [PATCH net-next 08/20] net: dsa: change scope of ageing time setter To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170519210055.9366-1-vivien.didelot@savoirfairelinux.com> <20170519210055.9366-9-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Mon, 22 May 2017 12:29:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519210055.9366-9-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2017 02:00 PM, Vivien Didelot wrote: > Change the scope of the switchdev bridge ageing time attribute setter > from the DSA slave device to the generic DSA port, so that the future > port-wide API can also be used for other port types, such as CPU and DSA > links. > > Also ds->ports is now a contiguous array of dsa_port structures, thus > their addresses cannot be NULL. Remove the useless check in > dsa_fastest_ageing_time. And you are also passing just the ageing time value, and not longer the full attribute, which is a nice simplification. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian