mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	soc@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/10] ARM: pxa: use software nodes/properties for GPIOs
Date: Fri, 28 Jun 2024 22:59:53 +0200	[thread overview]
Message-ID: <ed9dd921-56a6-48cf-9f25-b8bb079c4249@app.fastmail.com> (raw)
In-Reply-To: <20240628180852.1738922-1-dmitry.torokhov@gmail.com>

On Fri, Jun 28, 2024, at 20:08, Dmitry Torokhov wrote:
> This series converts legacy pxa boards (spitz, gumstix) to use software
> nodes/properties to describe various GPIOs instead of relying on GPIO
> lookup tables. The benefit is that structure and behavior is closer to
> DT-described GPIOs.
>
> The very first patch ("ARM: spitz: fix GPIO assignment for backlight")
> is actually a fix that IMO should be applied sooner rather than later,
> the rest of patches are enhancements. The reason it is sent with the
> rest of the series is that later changes contextually depend on it.
>
> The last patch ("ARM: spitz: Use software nodes for the ADS7846
> touchscreen") soft-depends on corresponding changes by Linus Walleij to
> the ads7846 driver in input tree. It compiles without it, but the device
> will not sync with display refreshes. I have created an immutable branch
> (branched from v6.9) at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git ib/ads7846-hsync
>
> in case you wish to pull it in.
>
> Regretfully it was only compiled as I do not have access to the relevant
> hardware.

Hi Dmitry,

I'm happy to pull these in directly, hopefully with some extra
review or ack from the maintainers. If there are no negative
comments, feel free to resend them to soc@kernel.org for me
to pick up.

Is your goal to of the series to eventually convert all
gpio descriptors over to software nodes, or are you working
towards converting all of mach-pxa to DT?

In the latter case, note that the reason we kept these
specific board files is that they have reasonable support in
qemu and you can probably figure out how to test them if you
try hard enough. I have not tried myself though, and there is
a high chance that current kernels won't boot without extra
fixes.

If your goal is to change all board files to software nodes,
I think we should take a step back, since most of those boards
are likely to get removed anyway. Two years ago, I removed
almost 90% of the board files remaining at the time after
showing that they were pretty much all unused. I kept the
ones that either had known users, or that someone wanted to
keep for some reason and work on doing the DT conversion.
For most of these (including PXA), there has been no work
on this in the past two years, so I think we should ask the
same question again and see which ones we can just remove
this time.

      Arnd

  parent reply	other threads:[~2024-06-28 21:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 18:08 Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 01/10] ARM: spitz: fix GPIO assignment for backlight Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 02/10] ARM: pxa: consolidate GPIO chip platform data Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 03/10] ARM: pxa/gumstix: convert vbus gpio to use software nodes Dmitry Torokhov
2024-08-06  7:19   ` Arnd Bergmann
2024-08-06 16:58     ` Dmitry Torokhov
2024-08-06 20:36       ` Arnd Bergmann
2024-06-28 18:08 ` [PATCH 04/10] ARM: spitz: Simplify instantiating SPI controller Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 05/10] ARM: spitz: Use software nodes to describe SPI CS lines Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 06/10] ARM: spitz: Use software nodes to describe audio GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 07/10] ARM: spitz: Use software nodes to describe LCD GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 08/10] ARM: spitz: Use software nodes to describe MMC GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 09/10] ARM: spitz: Use software nodes to describe LED GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 10/10] ARM: spitz: Use software nodes for the ADS7846 touchscreen Dmitry Torokhov
2024-06-28 20:59 ` Arnd Bergmann [this message]
2024-06-28 21:08   ` [PATCH 00/10] ARM: pxa: use software nodes/properties for GPIOs Arnd Bergmann
2024-06-28 21:44   ` Dmitry Torokhov
2024-06-29  7:34     ` Arnd Bergmann
2024-06-30  8:07 ` Linus Walleij
2024-06-30  8:41   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed9dd921-56a6-48cf-9f25-b8bb079c4249@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=daniel@zonque.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®