From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD84C4338F for ; Thu, 12 Aug 2021 12:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90D096104F for ; Thu, 12 Aug 2021 12:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235630AbhHLMSX (ORCPT ); Thu, 12 Aug 2021 08:18:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:35176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234942AbhHLMSV (ORCPT ); Thu, 12 Aug 2021 08:18:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21C7260FD7; Thu, 12 Aug 2021 12:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628770676; bh=hPO/RgigXZIs0Z1FajHF6364OnjOffqwUiOdt5UM+nY=; h=Subject:To:References:From:Date:In-Reply-To:From; b=JtNZuWjGBG9wnDAVj6jC6VLhI3i3WTJ384vlUBlruCSMI78HFPKISeU0PSHTNSW9Q xgae88WAwRjEVp07Kp4nCI16VqohDclFllFTTDUEscbiStegVFwICiB02csZS4amJd zqfQ3zfYTQfX3mlug0FZgxPS1xxHAyX63FV76wl/IOy3eANjF/Jyem5pgnXtMOaE15 35uFip7/exR/FqjlDPNVFWDKGEz7l+nR6KxKi4cqNEqMSxGfo6qCIDI7f7MrNjjr8Z 1Xo3ceJxiWH3ldQSqt0IbL5/ADzXOWCEFq+7mG4/vWZVVREBpdr7Xf2U4xVtml9a+l i8pLiAjtR9riA== Subject: Re: [f2fs-dev] f2fs do DIO write make file corruption To: Wu Bo , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <5b68208b-fd94-bf4e-fc4b-d79d13abf1c6@vivo.com> <6519b8b7-1eb0-f286-7593-5c5ebbfb5554@kernel.org> <86e53ee7-13b5-5e8e-7c81-acb1736ebc8b@vivo.com> From: Chao Yu Message-ID: Date: Thu, 12 Aug 2021 20:17:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/12 10:55, Wu Bo wrote: > > 在 2021/8/11 20:57, Chao Yu 写道: >> On 2021/8/11 11:28, Wu Bo wrote: >>> >>> 在 2021/8/11 11:03, Chao Yu 写道: >>>> On 2021/8/11 10:48, Wu Bo wrote: >>>>> I use the following command to create a file, the file may got >>>>> corruption: >>>>>      f2fs_io write 2 0 512 inc_num dio $path >>>>> >>>>> And when I use bio or to set the chunk size to 1 block, the file is >>>>> normal. The commands as following: >>>>>      f2fs_io write 2 0 512 inc_num buffered $path >>>>>      f2fs_io write 1 0 512 inc_num dio $path >>>>> >>>>> I find this bug on old kernel version 4.14.117, and not find on version >>>>> 4.19.152. So this bug is fixed. Can anyone can tell me which patch >>>>> fixed >>>>> this bug? >>>> >>>> Not sure, >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.19.y&id=7bae8b6b73e46c307fa355ce086800b7ad6610f8 >>>> >> >> I didn't see this patch in 4.14 stable kernel of mailine, so do you mean >> 4.14 kernel >> maintained by Android? >> >> If so, f2fs codes in between 4.14 and 4.19 Android kernel are almost the >> same, >> see below link: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git/ >> > > Sorry, it's our old Android project code.So the kernel version may have > no reference value. > This project code last sync to Android common kernel is: > 9f892496fc0b:f2fs: readahead encrypted block during GC[2018-09-05] > The code link is: > https://android.googlesource.com/kernel/common/+/9f892496fc0b > And after that, we applied some fixup patches. I think you can pick up patches from your 4.19 f2fs codes which are not in your 4.14 f2fs codes, and check each patch you picked to see whether there is a patch can fix that problem. Thanks, > >> Thanks, >> >>>> >>> >>> This patch is applied. The issue occurs when f2fs dio try to preallocate >>> multiple blocks and got scattered disk blocks. The log as following: >>>         my_f2fs_io-13425 [002] ....   395.583637: el0_irq_naked: >>> 1:type:1,ino:40132,off:768,old_blk:0,new_blk:185764 >>>         my_f2fs_io-13425 [002] ....   395.583710: el0_irq_naked: >>> 1:type:1,ino:40132,off:769,old_blk:0,new_blk:205824 >>>         my_f2fs_io-13425 [002] ....   395.583721: f2fs_map_blocks: dev = >>> (259,23), ino = 40132, file offset = 768, start blkaddr = 0x2d5a4, len = >>> 0x2, err = 0 >>>         my_f2fs_io-13425 [002] ....   395.583735: f2fs_map_blocks: dev = >>> (259,23), ino = 40132, file offset = 768, start blkaddr = 0x2d5a4, len = >>> 0x1, err = 0 >>>         my_f2fs_io-13425 [002] ....   395.583741: f2fs_map_blocks: dev = >>> (259,23), ino = 40132, file offset = 769, start blkaddr = 0x32400, len = >>> 0x1, err = 0 >>> >>> And if the blocks are continuously, the file data is normal: >>>       my_f2fs_io-13425 [002] ....   395.584037: el0_irq_naked: >>> 1:type:1,ino:40132,off:770,old_blk:0,new_blk:205825 >>>         my_f2fs_io-13425 [002] ....   395.584066: el0_irq_naked: >>> 1:type:1,ino:40132,off:771,old_blk:0,new_blk:205826 >>>         my_f2fs_io-13425 [002] ....   395.584077: f2fs_map_blocks: dev = >>> (259,23), ino = 40132, file offset = 770, start blkaddr = 0x32401, len = >>> 0x2, err = 0 >>>         my_f2fs_io-13425 [002] ....   395.584091: f2fs_map_blocks: dev = >>> (259,23), ino = 40132, file offset = 770, start blkaddr = 0x32401, len = >>> 0x2, err = 0 >>> >>>> >>>> Thanks, >>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Linux-f2fs-devel mailing list >>>>> Linux-f2fs-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >>>>> >>>> >>> >>> >>> _______________________________________________ >>> Linux-f2fs-devel mailing list >>> Linux-f2fs-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >>> >>