From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93469C433EF for ; Tue, 28 Jun 2022 11:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344581AbiF1LtT (ORCPT ); Tue, 28 Jun 2022 07:49:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344313AbiF1LtS (ORCPT ); Tue, 28 Jun 2022 07:49:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2572860D5 for ; Tue, 28 Jun 2022 04:49:11 -0700 (PDT) Received: from [192.168.2.145] (109-252-118-164.nat.spd-mgts.ru [109.252.118.164]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3321A660184F; Tue, 28 Jun 2022 12:49:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656416949; bh=HGQEPLnVH+jJ83Zot50l0PdSWCuDqpbeVYS48mJP2vs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kdJe+hsxGDkqHitC4VywwVUdMSa0p1LJvIbmEMvG8yLFoS8FoF05EUhaL7RdtdOiL ODglyQWuRcqO8Z4xTd9YwEoObsgo/eMMBpbHCocY/hUgQ9X3Wj888YUAqLbMXakCvd AjV+jKscFH196pEGB/x6rxUPw3eYVPWpp92JrejLsBjhM+zkPwa7hl6ZeTZlusqnGV gqrYQnbaGmY3NjMUyYfdk4tQJ82vMXZbgFv5xicP4WfdL6eSFVPfQo/UezmQ9Z9Bpo 2B/QR++KoJOGMprTXnWMhvpZzccFpEOU2BTwAYxT+d6+8LfU8Q9I6U6caMsZyxmTI/ y3ZDg+Bvli1Mg== Message-ID: Date: Tue, 28 Jun 2022 14:49:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] soc: mediatek: Introduce mediatek-regulator-coupler driver Content-Language: en-US To: AngeloGioacchino Del Regno , matthias.bgg@gmail.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, alyssa.rosenzweig@collabora.com, nfraprado@collabora.com, digetx@gmail.com References: <20220628110128.64137-1-angelogioacchino.delregno@collabora.com> From: Dmitry Osipenko In-Reply-To: <20220628110128.64137-1-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angelo, On 6/28/22 14:01, AngeloGioacchino Del Regno wrote: > + mrc->vsram_rdev = rdev; > + } else if (!strstr(rdev_name, "vgpu") && !strstr(rdev_name, "Vgpu")) > + return 1; Nit: checkpatch --strict should warn about the missing {} here. In general braces are always needed for each condition if they were needed once in the if-else. Reviewed-by: Dmitry Osipenko -- Best regards, Dmitry