From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57542266565 for ; Sun, 19 Jul 2026 14:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784469990; cv=none; b=NaIvgsK2n+kAXh0Y5w9eMy4qFRaOCd2v8hFi6daAiYwH0ZtWtKNtS6FBVckURukFkJFf7P5Jd5fEJA1mKDwQgIExjr/Tnlrij2SOqs3LUM5gcph4lcMsSl/XkA39SOJDOiPTsvFn+xnTAj8TjYaoDAsIpQgBfFCJbs8lCObQZ0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784469990; c=relaxed/simple; bh=tBxl358zMsXKLv7H4hC2rLLqhGkmvSxkoHKch3Scrp8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X9Jhq3GkS5MGJCF7cBESWZlkpG/jVC8PWGsC6jEq/WZxbKSEjlmpphHhzr6/ye5cI9oy7j4vImP+kllhvdCD0XZa24ea3HcHQjo/xWF52v+kBSdi1DDg12wPngTNXveoi9rn1JZ58Ux/0Ba8M/U3LdTmynV0IKPvCUHqw//ZuTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YeXe/WaO; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YeXe/WaO" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38175907a56so2179127a91.0 for ; Sun, 19 Jul 2026 07:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784469987; x=1785074787; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=X7+RSJ2zBvLkg7eE2oEuVngZetNyS5kmisVv2Dyb88s=; b=YeXe/WaOA6RZgufIrMbf4XLGSEb5lyxcrqo61hSmjyff++DJwAQKb/CloARVcOU6/D hjHSSdKoRNoiDBgoSr2+MTC5cdb042EUsnoJU/O/7UVKzHPm8fI9UKxbCglm/olWlXVX DnVdm1oNir+49vtbsKpuoDgJvXBkrn0WK1WDmpB5GgCt0ZfnRehQqEAV0QsaIYOm3I/+ v3oS0IUfoaiwvqkDEVdBLDNFIqjqxT9NOYXSarB29psr1RsmEegW8ioUd84a16zqilQY Z8zcih5gyqz6QgrfjR6lVJKsWZZRRNikUHc14orytpmsUuzE7YM2CyZ8YusqSab0VWFl P+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784469987; x=1785074787; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X7+RSJ2zBvLkg7eE2oEuVngZetNyS5kmisVv2Dyb88s=; b=YfqrfCDX5yXsTaeOfppe2bG45ekGgUzLw+2aoOFoLhFWITzUgj7o0Gb46WcEmzXzhA 3EWGH8vdOX416+2C5YR1ndT/bKjNynPUb+H45TaWBJYD5nKbFKTJQm/J2IJvHiZUZ65i umakI87Ad6TSjH3GVUmDOopI/s4aqRC8dCSG9Ty5hH6I7BCT4IiKinVtNlN0qzHuw1wO n25MGpn2dMtrkTLT3c+/jtG1v1g9qJXvbohDOCj22TV/IBBYGlNzWG9T9vAuJO4nx3oh cXutMD2+KtNtIhSjnu99es+5Ktri08RYQglknagWmDkzrk6mlFU/d1BRZKmYGbKcKwN9 yx4g== X-Forwarded-Encrypted: i=1; AHgh+Rq03KqG5QYxNkno+5Wh6F52L/wIBkCODjncEJdj3brAOvmTe42AlvZ/5IvP0rJjpvnStWYzyBZN9BJguts=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8FBmZW+Yr9uSgbgXG36XtIGbY3mewi5eTmyVIpOM/4KepMeCf 0YgVBcSw+mufQOQWEx+pFq4t5Aenw4MVj73zrJFI2Xezg0RhL+fmAWhZ X-Gm-Gg: AfdE7ckdYosmds5eEFEj/bnHuZSWYPQuwaPwpcwFlUSrcbh9b1ikkUtAIs9nSrbII/I h/WJKCE+aMJ/P/L1/o6livIE3S67Q9cGMD9TYiVtK5hdgFy/TwJuTQswKtWhMx9qofIbgDfqq0x R7/Z1GrORGADLveggKLXo4o/VygTPQNrAB51hrglXHXvTTqoTOI6L1pbz+7oX8wxCoEc18byZBC 0PaOGauRzZPQ4THRVqUcb4V0AHaZ6SaEdkWOrxtSKGCEZemaIMrtKRUB8uLKCQIU9tdAe7ccBU7 PeZscUyzQRVh5yyQX4UC3E2qWT4iO/aY/2I2Z0Dw35ACNyOxSvpEequsm1C4/MCe5Ah2mNKEj4c qyiQnvtrrBt1Hf2eWDivNM1v8oIWyo6CKnD3io/QZCtTs64Ffs9H0OxEJkfXtIHXpZ/ccmtnrhM 5zPFQIYEbLbrGO5ADRwp0Do+ANzA== X-Received: by 2002:a17:90b:2fcc:b0:37f:d265:18d2 with SMTP id 98e67ed59e1d1-38e4b5389ddmr9568508a91.7.1784469986701; Sun, 19 Jul 2026 07:06:26 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e39de7790sm6140653a91.3.2026.07.19.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 07:06:26 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 19 Jul 2026 07:06:25 -0700 From: Guenter Roeck To: Flaviu Nistor Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: (lm90) Switch channel parsing to fwnode APIs Message-ID: References: <20260717063730.5617-1-flaviu.nistor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717063730.5617-1-flaviu.nistor@gmail.com> On Fri, Jul 17, 2026 at 09:37:30AM +0300, Flaviu Nistor wrote: > Replace OF property handling with fwnode in the probe function to read > the channels properties, improving the driver compatibility since this > method is not limited to Device Tree only. > Add also the needed headers for explicit include and clean up related > function naming. > > Signed-off-by: Flaviu Nistor > --- > Changes in v2: > - Remove as suggested by Uwe Kleine-Konig. > - Link to v1: https://lore.kernel.org/all/20260713190659.4511-1-flaviu.nistor@gmail.com/ > > drivers/hwmon/lm90.c | 47 +++++++++++++++++++++----------------------- > 1 file changed, 22 insertions(+), 25 deletions(-) > > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c > ... > - err = of_property_read_s32(child, "temperature-offset-millicelsius", &val); > + err = fwnode_property_read_u32(child, "temperature-offset-millicelsius", &val); I understand you consider it to be irrelevant, but temperature offsets can be negative. Please explain how this is handled. Thanks, Guenter