From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A57101FF for ; Fri, 4 Jul 2025 08:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751618429; cv=none; b=Guh0suBHTakLpFd7+sX5yIWVeSMzOPU6dC7PKLROUoybTM68LzUyLK7EoVz+UvN3G4nTjJm1TZGDhud09Avlil7nEiabOd9gnlbMvo2jd5PQIwZ6nrPkcehTE8qd17S0RytY8ozN4ckGEZvIt6YXzt7OD7EGf5G2IYUtyKlUdII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751618429; c=relaxed/simple; bh=4MhLLZVxmgDwM/Tau4HiEsocpevlaGtLp4cPRiYCAg4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MMnHSVoFUIsZpj5LAEvR3/omEUAtHjS3h7NeRd/oRjz/xuo/W/4zAnNSpMuTKw7r16WHNqBQOo0LEEaXdA6QL8MMqtpXTj+sIyLEBQt2FzQigp3daZLPzPFit7SuoMGgv1SNXvPQF0wX0HT33nRHEHZT/LPe0+CfDxLIr8AK6q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Rq4tNqpu; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Rq4tNqpu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751618428; x=1783154428; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=4MhLLZVxmgDwM/Tau4HiEsocpevlaGtLp4cPRiYCAg4=; b=Rq4tNqpuRBbz/rgbf0BT7WnuZg8nK8C0ZuEdYqvXAX8XkPPn6ju58/h5 7WbN4DFFDQYnJbt+HLYVeR713acDHODci87poWbRlHjv20lkPZm519CZd id4i+qoVwufRfUQxfP7CzbNwtOm1AkgqyqgNN7+M1VYxfaPEaWiA6KQM9 g+n1uslCYvO3jei7/7nJitorzDmgU2d29fMt/Pb4KrlTFOG3MkYAxfxgu 4HlwnXEhj2UgHpAjn/4KJAp1Hgi0pK/cmMJC9qauhGEJiUbUiFRK5QAoP Xo8u44JfvuESj0xV3AzdwcanhCn16JVlU1LhVUD/PNxOri6HpWqVHTdJU w==; X-CSE-ConnectionGUID: t7dVsBNHQpOml6fOi9R5eQ== X-CSE-MsgGUID: cw9EKN9YShqMWHnCV0Ca1w== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="54049609" X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="54049609" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2025 01:40:27 -0700 X-CSE-ConnectionGUID: JgE13aYOTnCKuRgR/xXS4A== X-CSE-MsgGUID: 8mE3MhZaRNaExJppMipy4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,286,1744095600"; d="scan'208";a="185547052" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.102]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2025 01:40:24 -0700 From: Jani Nikula To: Lucas De Marchi , Ville Syrjala Cc: linux-kernel@vger.kernel.org, Dibin Moolakadan Subrahmanian , Imre Deak , David Laight , Geert Uytterhoeven , Matt Wagantall , Dejin Zheng , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 1/4] iopoll: Generalize read_poll_timeout() into poll_timeout_us() In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250702223439.19752-1-ville.syrjala@linux.intel.com> Date: Fri, 04 Jul 2025 11:40:20 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, 03 Jul 2025, Lucas De Marchi wrote: > On Thu, Jul 03, 2025 at 01:34:36AM +0300, Ville Syrj=C3=A4l=C3=A4 wrote: >>-#define read_poll_timeout(op, val, cond, sleep_us, timeout_us, \ >>- sleep_before_read, args...) \ >>+#define poll_timeout_us(op, cond, sleep_us, timeout_us, sleep_before_op)= \ > > nit: could use use usec/msec etc that pairs nicely with USEC_PER_SEC > and friends, also used by tools like perf and are a little bit more > greppable than ms/us? This horrendous quick and dirty git grep popularity contest says _us/_ms suffixes are much more popular than _usec/_msec in kernel: $ git grep -aoh "_[mu]s\(ec\)\?[^a-zA-Z0-9_]" | sed 's/[^a-zA-Z0-9_]$//' | = sort | uniq -c | sort -rn 8603 _us 5901 _ms 1214 _usec 736 _msec BR, Jani. --=20 Jani Nikula, Intel