From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371DB33EB18 for ; Tue, 20 Jan 2026 16:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768928046; cv=none; b=J0aQFY8u5Guf58IXM/x4VydpGxAIo9p7gL1EechIcviUsaOL4xJTmNCGC4fHb3pX+P7tjABg0R/njx37vyVP4Ms9oUR1mKNNUbQrWolpxC6Hss2KD6taqCXK6unpGgWQGkqMYP5C5vPmbLarjscagjfokL3BDLT5+8K/V1XRcEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768928046; c=relaxed/simple; bh=Xh5NhbusMKugFJN+jyX+RAwANK94Y1YcdWvZxclernI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uWbw2gtwhBcjIQKGShK1O2AYvsHjjJg2FsGZLLiYbTkL3Gf7160yP+u7U58IKDS4lAyg+B6B2B5tSc7arF6CshTi1zVmAsXDSoyapslHiYbv8ZDrhcEg/3nboFWBJyVQxWMCgHKWPN6dHMKvxNguvx858oa5mGzW8PCveDNwkf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X6Q6Q7Na; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AAhfZGfB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X6Q6Q7Na"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AAhfZGfB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60KCxAEt797938 for ; Tue, 20 Jan 2026 16:53:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xQH8/RM6VC8rU1HZ+RTjzOS2KZDYo8OMBNTFVGcVfA8=; b=X6Q6Q7NaIlQVfsHh /4tut6VsbqZpTQhdn3jj/OmDh3yV8kGy/XhZH46s2QicIaNam1nw/o+vWtyZ3GEL V6rpT/5EtG3tE/xkn1hj0bCQVJlp6s2io+TjSUYM7Dq25gijNu/F1jVi36eq++S8 Ozf0S9E5A/eNn2EB2FePe2yl6Bn1DPmRW9i2i1IcWkPel3lQThZkVtc22Zw3CtgP GfIA+b/J9eoW/d4JvodzpUyXWB9KbyGZEcbVDzFQ9/lI0e29GsGnwVwMg3aXKKOi y7TXhgfkqYT3BOv1SdnGGESyodm2cq081htQR1mHbAOadr/1YDsJlltI0a79TYEN GZDIQg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bta6q0r9q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 16:53:57 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81ed3e6b917so5141196b3a.1 for ; Tue, 20 Jan 2026 08:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768928036; x=1769532836; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xQH8/RM6VC8rU1HZ+RTjzOS2KZDYo8OMBNTFVGcVfA8=; b=AAhfZGfBxbVhKViqcGjguptC2WH34uD9P4wwWB9WxgGk2/4W0dMjqLsSou9nLkuuNh kZJnrjow7d9xupDvzE28dO7loA21VXf/4oQ2mOQYB6E0rcshPOl5gO3oeT0cOjAJVORr swvQkCui1uksLGOaCV/io0CjvJNhHzYYUTneu0rau1FJG2qBLA4lzWUt2lWLSEO/9C4b dVImJRlZleNBCKrZ/HHMNZfdfAQyg4fYHcGzFer5GOrvf09v82XzqUCvMlWuxPBlhqfM uc9rO4SF0JqJD8Pb+7CtLD2fUWNDOTFroBgp9u1NLKK8Cp1RDoIjw7b3xL/dDCJPl7tx J2pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768928036; x=1769532836; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xQH8/RM6VC8rU1HZ+RTjzOS2KZDYo8OMBNTFVGcVfA8=; b=m4v3jzCCUayctV9tcPelEJfXYB//5QIcGNZEtW7uUsIOjxl7V2YhiblSZbqtl5IUJ3 YkwyB4hOFC6ykFC6YrDQbpEVDoNjZHzR0e9vOL0mXFac+HY9vkHY6eBXsQEghM7NZD62 E4rgphWSNN0BWEnSM2lLxpr+hQoqSCyD8H9/N1fOKgKiaG724MIv20QIKA21zu35ahtL HRJbgwp9sMmmWGNRXjfWQN2nXoDSXer6SJoBh+hJB5riz+7ihEAioLJg/PI0ePKhih5F PzFP/fmwI0DBfyNuYr6z2lu4Pn6Id1ZDhC4yU4nG/ocDGeAvlqlXiNpcQ+BK9XYOO2CW k+Mg== X-Forwarded-Encrypted: i=1; AJvYcCVqFFZilwz06XlppFfhuBGbt6b3AVy81yUww1Yil7NRtWMaqNm00D13+KcXgwUu6kNIh1E2mbbeeMiHjEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7oUvd1yCjY4LB1Zz1XHYCipWKZisslsOXxZzyzjubq4MOesRk 5rehXu+S2yk2gYBskFa0BXBsDZPXYSzwR91So5Dvke9OtCJQFqsdc5sQeBb7UkzZitZTsiKW2Ay FfFZVdBCQ8gN9H2o9jsxMmUbGVMBCbF+DtNOWnluzysRUap6bda57QbJ8PMXmj2kSXcU= X-Gm-Gg: AY/fxX7Wu5kDOgt4dId2LR7D0BtkkPo4A2IIOh2otRNZo/77OLfT+rizVn+nT52B5cR HUphOckCzFHapOHzUqmBNZkNVFAqspQDv9AiM72nNgA9yfifN76+h2daM04p8+0ZjZfcxA9GVMN FRLSIcCb9K/LWh4hwy5rzA0a5bqfEiraK+etnFOOFu2yx41sN8dYdrDfyhxh8SR0wR6o55PTowu ZZSFUwOWaICKv0rWUTQWjLFzaqI3RS1Ax+BGKgi+SUgJZpjqsY5iVYwWJC4LvWuvu2iqujrRkIO v+FRVnRP4TntlLzy04Iwlbjzbef2ZmnrDySUBwlpfTQN7ktUpwj2wWQKhrOdgAlrb/vX7ECrqwI aCOXZQ6tVgzPwO30MElHY2qXvz0OeBPKAmu61Hg== X-Received: by 2002:a05:6a20:d81a:b0:38d:ec2d:80e5 with SMTP id adf61e73a8af0-38dfe71dccfmr14977000637.45.1768928036283; Tue, 20 Jan 2026 08:53:56 -0800 (PST) X-Received: by 2002:a05:6a20:d81a:b0:38d:ec2d:80e5 with SMTP id adf61e73a8af0-38dfe71dccfmr14976971637.45.1768928035633; Tue, 20 Jan 2026 08:53:55 -0800 (PST) Received: from [192.168.0.195] ([49.204.25.225]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190eee4fsm127957315ad.42.2026.01.20.08.53.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 08:53:55 -0800 (PST) Message-ID: Date: Tue, 20 Jan 2026 22:23:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: dispcc-sc7180: Add missing MDSS resets To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , cros-qcom-dts-watchers@chromium.org, Kalyan Thota , Douglas Anderson , Harigovindan P Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260120-topic-7180_dispcc_bcr-v1-0-0b1b442156c3@oss.qualcomm.com> <20260120-topic-7180_dispcc_bcr-v1-2-0b1b442156c3@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20260120-topic-7180_dispcc_bcr-v1-2-0b1b442156c3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=QohTHFyd c=1 sm=1 tr=0 ts=696fb325 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=NUZ/Q5sP+scsJfd5oYcUKA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=EEUffno1QXpLnStXY5cA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDE0MCBTYWx0ZWRfX4C9TE8WJqhXR b3A7CTpEzrIdmwtO2zV8A1eiheMbKzvjm3tcYzY0ciJWb8JX5YvbkIXF54kg3tHiS88hW+UvMid TpuJ/PeUuqSfBPeQnwK29yzeMCROLuQKGoFfbLcaP7psuP+uWva+Tpa5J5LtDBnKA30Hpm2rnGO poZ3ND1ncHTlWnKpzghvqt84y7GzglRbym/bS8JRI4L9QqZerAEj4yzkU754ry+O63p3e53tkvo tJDmpBXza+lTnlxxCke8EZlVm1pevI15YUAfs9EserQQ/3UWcKo+8DAmWuEKXiRWU1hmpByAS8K HCqLcrY7W6EhW5MpRte1gl0HLuCQx1l3HyvIWxOXviolx6EHvTMZ7xUtfDSkgJyGzVkV4p2fNKX /9EAHcMr3p5nQkU1Ye59ONPlw0csjtX/sMvfhEeS3H6EuNC3gjfxHwR2I7MqKq5AbdZEOhFEuvB a0nV9t+LgHExcINvVHA== X-Proofpoint-GUID: 3Epx3TTZniQ8c_3OEzogSZcEckwCRr_G X-Proofpoint-ORIG-GUID: 3Epx3TTZniQ8c_3OEzogSZcEckwCRr_G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-20_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200140 On 1/20/2026 4:49 PM, Konrad Dybcio wrote: > From: Konrad Dybcio > > The MDSS resets have so far been left undescribed. Fix that. > > Fixes: dd3d06622138 ("clk: qcom: Add display clock controller driver for SC7180") > Signed-off-by: Konrad Dybcio > --- > drivers/clk/qcom/dispcc-sc7180.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc7180.c b/drivers/clk/qcom/dispcc-sc7180.c > index ab1a8d419863..d7e37fbbe87e 100644 > --- a/drivers/clk/qcom/dispcc-sc7180.c > +++ b/drivers/clk/qcom/dispcc-sc7180.c > @@ -17,6 +17,7 @@ > #include "clk-regmap-divider.h" > #include "common.h" > #include "gdsc.h" > +#include "reset.h" > > enum { > P_BI_TCXO, > @@ -636,6 +637,11 @@ static struct gdsc mdss_gdsc = { > .flags = HW_CTRL, > }; > > +static const struct qcom_reset_map disp_cc_sc7180_resets[] = { > + [DISP_CC_MDSS_CORE_BCR] = { 0x2000 }, > + [DISP_CC_MDSS_RSCC_BCR] = { 0x4000 }, > +}; > + > static struct gdsc *disp_cc_sc7180_gdscs[] = { > [MDSS_GDSC] = &mdss_gdsc, > }; > @@ -687,6 +693,8 @@ static const struct qcom_cc_desc disp_cc_sc7180_desc = { > .config = &disp_cc_sc7180_regmap_config, > .clks = disp_cc_sc7180_clocks, > .num_clks = ARRAY_SIZE(disp_cc_sc7180_clocks), > + .resets = disp_cc_sc7180_resets, > + .num_resets = ARRAY_SIZE(disp_cc_sc7180_resets), > .gdscs = disp_cc_sc7180_gdscs, > .num_gdscs = ARRAY_SIZE(disp_cc_sc7180_gdscs), > }; > Reviewed-by: Taniya Das -- Thanks, Taniya Das