From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623BDC77B7C for ; Sat, 29 Apr 2023 14:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbjD2OY6 (ORCPT ); Sat, 29 Apr 2023 10:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjD2OY4 (ORCPT ); Sat, 29 Apr 2023 10:24:56 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CE5A170D for ; Sat, 29 Apr 2023 07:24:56 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8947A5C017D; Sat, 29 Apr 2023 10:24:55 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Sat, 29 Apr 2023 10:24:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1682778295; x=1682864695; bh=GZ 1r8chqJu9O8N9mQjNNJZHcqb8s0kPL+Id1lipx7Gg=; b=TP+xxB5Xv5L5XaMTCz JvKdo4SJevmykIap/mU0DRhRvX8IKLEIEiABHua2KzggZII0h5vEkR01aPwrk6+a ktd5fTqHkoHNzkkKr6JIDw7Duq1uTjut1PWJo8z4/zWkMnbFuxPHeUlUwN6IxlAD UyeVjxmZqFoo4fZPlyr3/0/ZJFJLhkfqX+Cq2CRBSD+qFW3MnT8/avTtc/dc+lzv AXOEKvaD035j5HGJmogUyit0/Q1EUzr2XZKyTtAvSVdldYhWuN5ZUMDUnbUG21pL P+syKL3IXrxUaFkDzV6hFIvEaUi4vWcBY/xoxik4lUOsetsxohqW1rC9mM+HSomS P5HQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682778295; x=1682864695; bh=GZ1r8chqJu9O8 N9mQjNNJZHcqb8s0kPL+Id1lipx7Gg=; b=PSYVGaqH2TMG9Qz8xtbHPZ3E0/VdM zY0EIRGX18ZjLWbg2e84R56Xs0V9jNL6RsPV2EOZ9ciLBe4SZw9uSZ6POLWHnwKv MRZIXNDK9EdQ9SWH77Fxnm1WQrOXw7JqG4B6W1vDL/icfnSxFvxN3hS/fpBpmw7O vXH7pQDQ7FMFNyqH1ZZxx+gxdJrH29xgN4fHsMlhEQU0RwrAXQuIML13FqWzVFcC gP6xBdqbqGp5LJalhbnarXHTh79HuoRL2G50/V+evjB8sBY2uH1d2yPDGNeKN4en YcGjCuAWQJpcfssKXFKsdKwXxznPZFefBECQNQa9gWx17glf9mm4GhBvQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvtddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E3C5CB60086; Sat, 29 Apr 2023 10:24:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-374-g72c94f7a42-fm-20230417.001-g72c94f7a Mime-Version: 1.0 Message-Id: In-Reply-To: <20230428221240.2679194-1-trix@redhat.com> References: <20230428221240.2679194-1-trix@redhat.com> Date: Sat, 29 Apr 2023 16:24:34 +0200 From: "Arnd Bergmann" To: "Tom Rix" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: remove unneeded if-checks Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 29, 2023, at 00:12, Tom Rix wrote: > For ppc64, gcc with W=1 reports > arch/powerpc/platforms/cell/spu_base.c:330:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 330 | ; > | ^ > arch/powerpc/platforms/cell/spu_base.c:333:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 333 | ; > | ^ > > These if-checks do not do anything so remove them. > > Signed-off-by: Tom Rix The original intention was to document that there are other flags that could be handled here, but clearly nobody is adding code to spufs, so there is no point in keeping that. Acked-by: Arnd Bergmann