From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935474AbdKPOmv (ORCPT ); Thu, 16 Nov 2017 09:42:51 -0500 Received: from mail-co1nam03on0078.outbound.protection.outlook.com ([104.47.40.78]:2779 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933733AbdKPOmm (ORCPT ); Thu, 16 Nov 2017 09:42:42 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [Part1 PATCH v7 00/17] x86: Secure Encrypted Virtualization (AMD) To: Borislav Petkov , Steve Rutherford Cc: Brijesh Singh , x86@kernel.org, KVM list , LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Andy Lutomirski , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LDg+KAnsOCIG3Dg8aSw4LCocOD4oCmw6LigJ7Cog==?= References: <20171020143059.3291-1-brijesh.singh@amd.com> <20171116100222.k3zic3ut3ectnaly@pd.tnic> From: Tom Lendacky Message-ID: Date: Thu, 16 Nov 2017 08:41:47 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171116100222.k3zic3ut3ectnaly@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BN6PR1101CA0021.namprd11.prod.outlook.com (10.174.237.31) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f029e7c1-1c99-4588-b2b8-08d52d004997 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;3:OnGrRz78GTd32BpeI8cXzAXzWe5ieqRghSseAvRVKMiN+Z04jqTAQspfPN+XiWPwBCIjAqrM1y+P3CN88SmHEuIjCDw13nQv3s6ha62mhKF9vCnM6li7M1En1iO9MDj+wMSgetj2uoDBWMAEhVNe+jaZgL4JyUfy8MWAILm43qsFgcXSu8w/KXy0mqizKsv4nkKvdZBd99swZMLC2BkJxlYW3+iKkWpqP2JWZ5vF54JoQo1+/OnwxOYbFtuGP9F5;25:oWTwo/0nlZ2ebeISt0QDwn15/B9cU3r9ZsH/3ERUydZKb1CsDkJFmaqg3hYuibrZeQ4XwZaidPQanqlrrQpyS2tasxhU39J/eusxTG2SYhS4tU1aSL4el7fhJYw0t5K8qADlXvYu06rDVIUdptTStR6/fDTu/Z6E2Nl2fnSDRwpTUSq8fsUXdFsy3F02mlMi0shlVYN1yDhUpvArgR+iwwuzKDFgF13CsYQ+gO83nQhnQeuqr2QE/nLC3kYSkuD2oCpansOTmZTuMmqq3bt8mJCq2CGWbNNdhJC01D8gelYPRkyqUjYtbWUUl5jXvMBZgkWVgMpRHlVkctTyrxptlw==;31:NuhRJVhiFa3gj+J1WQikBX1FsmWw7VW9PJ66YHXYTt6QL9OlfNQqIM2Ag79TFNQh/CooazmuL+KmJ6ygSPq5uXH9Hx9OaVr2IeGNSW1Vp/PfkWiRYRBld1yOzc2d7RHYztGd4kwNcWNcaFgvrtqwF0V7JkCgVFA6YqUd6H/nT6ETMG2bxuk7HiznkH6EHsnU1juqC/z4cuIPfe3Oz6tP0gjv+dInVM1qpIDkQ+D/VIM= X-MS-TrafficTypeDiagnostic: CY4PR12MB1141: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;20:e7iAESkncaC0G15EeAkf7AkVxSJquDhPYV+NZV2Pk2xTS4fISLi3y3+MSXtdZeqOP2cPKo5jCDQS3zXtC2cuCeza2cHoAhrLKmHP108A4U9CWDGrfWJQjYZ+wk4U1l39vSNuEdZn5iqUSgVMMPAS0OnPA89hfHnH3qcZqKdPVu4JxGaI/ZfdgRMb+Yg0T2cdowYg5AMkVDHZ/MEiK5BrgnrrPMCgBIFP6S7hneYlR6Pl3/Y8+LFOLkpXx+Imrv7Pn7L1IaiuJLmjP18KtMUtH1sdyKQlmFoNCPS1W/itq2cTmiPNb4vKbnEMXDvmdi/KJo/5nh2ScbJHIr8eQTUTf7oJg3DJV2YNCvegKYP5ZtkDKBQTO2wDcaFDsjaM3O1aOCEUIAVewnwcYKki04TOBnQ2zwI7bFcWwGBMahvgE727B63bjuVGKOsxoTVBNTZ5mxv+AmW9FHthaIrfjKn0Ydvcm3ob6W4R0g4t0jsvmu8MGWlumVpZmP4bZeHr5ful;4:wXA6XS/UV7kwXKPbjS2FD9TGGe64OLX3EJM3Y0O5R1JuJ80oFd5DtG+KlL18xaTbCTIVO+u9cEAnbMg3GZGmLCAVWjANrd1Up5ZfVW/cFZaAT4zmos2B+i2Wjx5tnX3kkJ5PIFzn7Ulj7AWxd+yQT/EPNbuhob8S1vxHrXjyqwOKdFVl4RHF78aX47vQmL+JaX6+vQ7sObvC7HyMISIYXy1asiac4EmF/KoRNT0hFtCtcNpVzc76H+jxC1rpSq7h2RZ0cNH+VztwVbaucGR7ES4JUYQvVwqIm1NUo7kf0SU2BultbDZczQ9xK5TW41tc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231022)(6055026)(6041248)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR12MB1141;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR12MB1141; X-Forefront-PRVS: 0493852DA9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(24454002)(189002)(199003)(229853002)(66066001)(65956001)(72206003)(966005)(230700001)(7736002)(305945005)(5660300001)(36756003)(6306002)(478600001)(97736004)(31686004)(189998001)(81156014)(6116002)(50986999)(54356999)(6486002)(76176999)(65826007)(77096006)(7416002)(25786009)(47776003)(81166006)(65806001)(3260700006)(101416001)(90366009)(3846002)(53546010)(33646002)(16526018)(50466002)(23676003)(67846002)(53936002)(8676002)(2950100002)(83506002)(105586002)(2906002)(106356001)(86362001)(6666003)(68736007)(6246003)(16576012)(31696002)(64126003)(110136005)(58126008)(4326008)(8936002)(316002)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1141;H:[10.236.64.70];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOlFtWTlGeDZFOFBWS2oxTzFwZllTU24wZU5z?= =?utf-8?B?TlJidEhXS1dYUGJJYUxvV08yQnE0ZGNkUHZxamhENERLSFlDVWQyaGJOZ2d6?= =?utf-8?B?WUFEdXBZVHZqM2xyQVV5YlpqSnZUMU9VNkdsOThpNURIVkQ2V1FsdFVJam5x?= =?utf-8?B?MVVIWjMwamFyVEUwL3hpV0ZFeWtKSlJTZEhwSTlDbjBEL2VSRG1adjkxKzhD?= =?utf-8?B?UE1jUGhnd3RnSk1GcGRMWElISGgxTmFNUkQ4QUdnM3h6MW13eEkvM1ZiUXJn?= =?utf-8?B?a1VrZ0lyS0RjYUtrQWNYZG01b0RPZFJuTm9XMHhjSktOd3hxUEFOVFBTZFV3?= =?utf-8?B?Q0ZTUmxmY3Rob2VPV2NDNHhQUW9uUzJRaDRYakROcGxLcm5ZdGI4ckxRL0R2?= =?utf-8?B?YUM0SkN1emlvRnpoOXpOVzlyWnQwZXBvUFdXdXpEYmRxQU5WYjZETkFwR09N?= =?utf-8?B?SUs4L1UvQjc1VWQ2aTVRaGMyajZnbG1Sb3lQNE13NXZidHo0U3ZyZWlJRFFT?= =?utf-8?B?V3VncG84TXJwWDlyWnp0aS9EaVBLb1c0YTdsTnhRUFUrY0pscVo2a2tmdysy?= =?utf-8?B?dDd0aG4wWnB6ajMvS3U0ZkcwNnN2QmhGMzJhWHJaem44SmZRck9ERWdPRy9C?= =?utf-8?B?d2VjMU9SN1dQejRpTWgxeGU1WDIyK2xKbFR6U2RyYnNCV0dZbk9vdHdtRCtO?= =?utf-8?B?N0xsbEhqTUZoa2hrTWVVUEsrelVSYlVmamowNnFLMU1leFBmems5VmVSa3lQ?= =?utf-8?B?cFRXam9nSWlSRlR5Yzh2dFZFb2dSK0YrZGFkYjB0QUorS1krenVtRDBJdDJn?= =?utf-8?B?N3h4Wm9oYkZKL0Q0WHcrR0VUcXROV3ZCenNWNDdMcXBLME01T1dGZHdtU0sr?= =?utf-8?B?TVYzVFp2N1p3bi9WUHI0UmJ6Rk9yQ3BnL2RSWFhDdEUrQ3VyUzlQU0NBVlZO?= =?utf-8?B?bDdJSUlnQzFpekI5MTF2K2w5QnJkeTNsaDRaa1BFVWFKSGQzWDdua2hFUUth?= =?utf-8?B?c1h2dmpTSVl4cGVyZEVNRjh4djN0QmRMY2g2d3E5N3FJUEJZa01aUy9sTXRO?= =?utf-8?B?QjVXTlMwbXdEMkZhWWNXMmNtSlFZdjRybmtzY3lmRU10YXArRkNsSG5WK0M5?= =?utf-8?B?MkJERkFORkl3WnloQTEzQWpQbDVaMklyOUJaa3dtcjBucWhhOE9MbGdwdHp0?= =?utf-8?B?SzFkcEN2UkJlY0N3SHpjMlppU0FPdHVHYUVQb2tjVFRNR1J2YXlvS0lJWHVl?= =?utf-8?B?OG1ha2VmZ1pLZXhuSWdERzYrbkY0UGNFSllBRlQ1MEtaOHJWdmZaZ21YQmpP?= =?utf-8?B?dVpQcHNiTktRbUdrcWQ0RDlVUzluRTYxZDlJMkZTSGJIdDJtb3JUK2N0akQ5?= =?utf-8?B?cWN0Mm1WL1VUcDJHaXczckVjNmR1cXEvWjZPeHA4cnF3R0tVUTQrVG1HZE1V?= =?utf-8?B?Vy93TEs4WUlhM2c1NGZQSXFSMDFhWURrOVFKMi92ajlEMjVlVW12ajh5ak5P?= =?utf-8?B?aDBncnFrUVRTYkpjZ01OSHptZUNhQ0FhVll3MDduN3VOcXg5SndhSmVGT3dT?= =?utf-8?B?T0RaamMyVW1jdjJybENYdlFybW50VEdzWGMwWW9FVFUxemR4UnI2RXhGcEFx?= =?utf-8?B?U0NwVzVYMXlrb01pWEQ4aDJPeTJYQ3NxeC9RSFdKTmxyTDU2VktqL1UyN2FQ?= =?utf-8?B?VjJTTit6bm9CU3Rvbi9McG1CUExYaTRoT3gwTVc0bitrbjJpM0Fzb3grMDF3?= =?utf-8?B?bWx6UmRhSjNiT1R4b2NVZmVNVytpMytJMU90dStTRnlPSHBrMUpHUVBtWXFx?= =?utf-8?B?QjRLR3VGNnFCZkpHZDFydWJWOWRHUkxFZE1DVzlHRFBOTEJHOUhneUFxaFlG?= =?utf-8?B?UFo0LzdCRDZPc3EySE56OXFVV01VUHRzRFptUGg4YVJiZHFKbmFSY25tOVI3?= =?utf-8?B?S0dsRDZLY0E4T3BienRNMmRsNmVXd1RQdCtKYm9VSDAya3I4bUh4TkhFVWxK?= =?utf-8?B?a3ljN3pTTFlBbEgyZ3c0dWtvVldMRnJLSkxwUW1VRE9zOEtIdDgyR0xyQUVk?= =?utf-8?Q?Nroc=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;6:3ywE5cGH9iLKUkD2ZP3Enn4YcbyIunpiYevHjGwSxmyMQv/SkvjE80/+TxHuC68/LmqGaEGndmGU9w+kOYEmYyrkVu3n4p2mP8E7vCP8dNQh0oFHqGYVgXHWrdiRpPEkX3kqlG2d4JR9RBV0af/wEVBclTT0usItxz9jfVl8a+Q6mKanyD7KPIYHVE94jYdtCexNSkdQWx2qiXuUM5jcKyWAk2B9uW4+7KG11iUO7I+7jUlGl1CegSXA0LLL1exsxqz0nLRHkJvGTh1avzhPhFVj9KLiNwT+DtQPeN4TI3wqvNVyAIo9W4EHFTYYDIjRSi+9PO8gKV3mYMs2Xyb25HJxr+3NJrJen/uVZF5gSho=;5:jqYS9PbF9n8nXcvHtWUanZbnwftmjDWkteE2q8ryXo8JKdB/vdheLDfXOniF9ACAuFxaZ4WU4he1ES7JMBPjn3ANxWiJrbNM3Z9I1Cy7ZqAZxO99FS2kbP/TG8pJ4bE0XxjuWeB/fdAX05cGdDEa5AtGVuCFLi3RlcW04ZYc7cE=;24:He1jKyS8O275KCa4T7woP3i5TUOWH5GhVEbHpAJJHPZKKBv/DsOyTWv2jdd9bmFr2Ibpd8YIuDqD0SDs6Os/N7Ja7AKtCnj3+HLE8O45b7Y=;7:/xEsBI3POiksDiVV59DDtiGdhbDjla42uME1LH7fHhxkWjDPowYBTAbuYJ4X/JmUhyCArkJxA1RAQ2hNu/8VZh3Cbw/7QrUqKmrvb7zvL2SwDLFRboiiwtbFcwPMI9N0Bj0zrZ57Y5hj6Hb96Pk5AMzY7h5rcYE1sZXaYIq7Y8gL23SGUNAlOTtHpPpj+ZDmwsPDlfJShJz9TH/86w2/4BJubDjxX5nLlMek4d2ttdPnGMGuhSe9aP+vfS0F0TZf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;20:1X23DLNA2MX7/55N1+l2qjNvdobD2/K0DbGxTGo9fRjxcFexXff1rn+6G2Pv4b777GVNLsqqaxaCbPdFs7Q/9xS+HHT6GRn/sv5R/9eIReiRTJUrUUSgRr/KgwSCH97Dp4tMTA1rRokRZI4IPpRY1zNmjySh5EtCY8pyKaVclsqWEYcJ6CWjQfU/2TfOoRIkstAScuzBHd4RQ6gvq3PU09gAqwu/UBTxzEpsDcomLT7z3vYICnKV4VFPRTA1ZnX5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2017 14:42:38.3690 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f029e7c1-1c99-4588-b2b8-08d52d004997 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2017 4:02 AM, Borislav Petkov wrote: > On Wed, Nov 15, 2017 at 03:57:13PM -0800, Steve Rutherford wrote: >> One piece that seems missing here is the handling of the vmm >> communication exception. What's the plan for non-automatic exits? In >> particular, what's the plan for emulated devices that are currently >> accessed through MMIO (e.g. the IOAPIC)? > > First of all, please do not top-post. > > Then, maybe this would answer some of your questions: > > http://support.amd.com/TechDocs/Protecting%20VM%20Register%20State%20with%20SEV-ES.pdf > > But I'd look in Tom's direction for further comments. I'm not sure what the question really is... MMIO works just fine using the data contained in the VMCB on exit (exit_info_1, exit_info_2, insn_bytes, etc.). These patches are for SEV support. If the question is related to SEV-ES (based on the non-automatic exit comment), that support is not part of these patches and will require additional changes to be able to both launch a guest as an SEV-ES guest and run as an SEV-ES guest. > >> Maybe I'm getting ahead of myself: What's the testing story? (since I >> don't think linux would boot with these patches, I'm curious what you >> are doing to ensure these pieces work) > > Seems to boot fine here :) Using these patches we have successfully booted and tested a guest both with and without SEV enabled. Thanks, Tom >