Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during device_initialize

[Max Gurtovoy <mgurtovoy@nvidia.com>]

On 9/30/2021 5:41 PM, Krzysztof Wilczyński wrote:
> Hi Max,
>
>> Don't use (-1) constant for setting initial device node. Instead, use
>> the generic NUMA_NO_NODE definition to indicate that "no node id
>> specified".
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/base/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index e65dd803a453..2b4b46f6c676 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
>>   	spin_lock_init(&dev->devres_lock);
>>   	INIT_LIST_HEAD(&dev->devres_head);
>>   	device_pm_init(dev);
>> -	set_dev_node(dev, -1);
>> +	set_dev_node(dev, NUMA_NO_NODE);
> We might have one of these to fix in the PCI tree, as per:
>
>    https://elixir.bootlin.com/linux/v5.15-rc3/source/drivers/pci/pci-sysfs.c#L84
>
> Would this be of interest to you for a potential v2?

sure no problem. Lets get some reviews first and then I'll send v2 with 
this patch as well.


> 	Krzysztof