From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03443EB64D0 for ; Tue, 13 Jun 2023 17:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240006AbjFMR71 (ORCPT ); Tue, 13 Jun 2023 13:59:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240019AbjFMR7Y (ORCPT ); Tue, 13 Jun 2023 13:59:24 -0400 Received: from sender3-op-o18.zoho.com (sender3-op-o18.zoho.com [136.143.184.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0349919B6; Tue, 13 Jun 2023 10:59:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686679125; cv=none; d=zohomail.com; s=zohoarc; b=E7lSMWkV7b5ODjNO7BK5WP5Ssg4jm20tHSnNq/e3F9lHXNxeIlmwoSoBR79du19K4HJBsz/NY7xLrBq4BY5Dv83G5zU/eXRcx/uWMTt0/w7o13+qeZNLlQz/0GWML34ZeLAXieAZH78br5N906djoyVXwz5Gc5/7zGDZw1XL4vE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686679125; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WzrVqvh/dDTqDYcbmTwhWyO6VLQD1qgqToUYYDQ/RoE=; b=DtJuxPts/TzNr9xeoUahNfThapMuO2eo2mUqa5Nmvt/jUvnYSp9o7C/ZPCJDg9B9ObR3/u6M2/AxlI4Sn48NaezK8RQtC4iMd+tjQ5W/yXOEhOFvFXZBleRxIUK2layNPRZ67qMxGRz7awboUPUlhb6qoOK+zBf+/ZzswG2/Vkk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1686679125; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WzrVqvh/dDTqDYcbmTwhWyO6VLQD1qgqToUYYDQ/RoE=; b=aE8QH8mAUu0WeIZHkrvypJMCH0MvzmPSDKBFMrxb7+q+Ug54uKZ6MC3vCEintK5O 7Bua4EQOsHjCxOFzPoFOxf7ie5q8e5a9Vf6/eYTijXyUjvdx7jM4SA26lo4unyN+iCs cNQ5At/73sitHYeJmMULF4wy3WATlBZneo3L1IWM= Received: from [192.168.1.248] (178-147-169-233.haap.dm.cosmote.net [178.147.169.233]) by mx.zohomail.com with SMTPS id 1686679123743537.1638599900879; Tue, 13 Jun 2023 10:58:43 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2023 20:58:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net v2 2/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7530 Content-Language: en-US To: Vladimir Oltean Cc: Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230611081547.26747-1-arinc.unal@arinc9.com> <20230611081547.26747-2-arinc.unal@arinc9.com> <20230613150815.67uoz3cvvwgmhdp2@skbuf> <20230613171858.ybhtlwxqwp7gyrfs@skbuf> <20230613172402.grdpgago6in4jogq@skbuf> <20230613173908.iuofbuvkanwyr7as@skbuf> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20230613173908.iuofbuvkanwyr7as@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.06.2023 20:39, Vladimir Oltean wrote: > On Tue, Jun 13, 2023 at 08:30:28PM +0300, Arınç ÜNAL wrote: >> That fixes port 5 on certain variants of the MT7530 switch, as it was >> already working on the other variants, which, in conclusion, fixes port 5 on >> all MT7530 variants. > > Ok. I didn't pay enough attention to the commit message. > >> And no, trapping works. Having only CPU port 5 defined on the devicetree >> will cause the CPU_PORT bits to be set to port 5. There's only a problem >> when multiple CPU ports are defined. > > Got it. Then this is really not a problem, and the commit message frames > it incorrectly. Actually this patch fixes the issue it describes. At the state of this patch, when multiple CPU ports are defined, port 5 is the active CPU port, CPU_PORT bits are set to port 6. Once "the patch that prefers port 6, I could easily find the exact name but your mail snipping makes it hard" is applied, this issue becomes redundant. > >>> So how about settling on that as a more modest Fixes: tag, and >>> explaining clearly in the commit message what's affected? >> >> I don't see anything to change in the patch log except addressing Russell's >> comments. > > Ok. I see Russell has commented on v4, though I don't see that he particularly > pointed out that this fixes a problem which isn't yet a problem. I got lost in > all the versions. v2 and v3 are out of my inbox now :) All good, I had to quickly roll v3 as v2 had wrong author information and I couldn't risk getting v2 applied. Arınç