From: "H. Peter Anvin" <hpa@zytor.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Alistair Strachan <astrachan@google.com>,
Manoj Gupta <manojgupta@google.com>,
Matthias Kaehlcke <mka@google.com>,
Greg Hackmann <ghackmann@google.com>,
sedat.dilek@gmail.com, tstellar@redhat.com,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@google.com>
Subject: Re: [clang] stack protector and f1f029c7bf
Date: Thu, 24 May 2018 14:56:31 -0700 [thread overview]
Message-ID: <edccc580-5dac-a747-4326-53f401c8fab9@zytor.com> (raw)
In-Reply-To: <CAKwvOdnKo4k_Q7dRF0vSq7FuwiDsy3hdx9kPvrgMrb5pV_nS2Q@mail.gmail.com>
On 05/24/18 14:27, Nick Desaulniers wrote:
> https://godbolt.org/g/oku8ux
>
> Is there a more canonical way the kernel does feature detection that looks
> better than:
>
Hm. I though we had, but it doesn't seem so. For cc we only seem to be
able to detect flags. For as we have rules that can detect new
instructions; something similar in Kbuild would be good.
> diff --git a/arch/x86/include/asm/irqflags.h
> b/arch/x86/include/asm/irqflags.h
> index 89f08955fff7..90974b5d023c 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -13,6 +13,8 @@
> * Interrupt control:
> */
>
> +#ifdef GCC_VERSION
> +#if GCC_VERSION < 40900
We don't actually test if GCC_VERSION is defined anywhere in the kernel.
We probably should explicitly define it to either 0 or some baseline
version if it is undefined. (Clang defines __GNUC__ so it will define
GCC_VERSION.)
-hpa
next prev parent reply other threads:[~2018-05-24 21:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 22:08 Nick Desaulniers
2018-05-24 10:33 ` Sedat Dilek
2018-05-24 18:12 ` Nick Desaulniers
2018-05-24 18:19 ` hpa
2018-05-24 18:24 ` Nick Desaulniers
2018-05-24 18:48 ` Alistair Strachan
2018-05-24 19:49 ` Tom Stellard
2018-05-24 21:33 ` hpa
2018-05-24 18:59 ` hpa
2018-05-24 20:26 ` Nick Desaulniers
2018-05-24 20:52 ` Nick Desaulniers
2018-05-24 21:12 ` Nick Desaulniers
2018-05-24 21:27 ` Nick Desaulniers
2018-05-24 21:56 ` H. Peter Anvin [this message]
2018-05-24 21:49 ` H. Peter Anvin
2018-05-24 21:38 ` hpa
2018-05-24 22:05 ` H. Peter Anvin
2018-05-24 22:31 ` Nick Desaulniers
2018-05-24 22:43 ` hpa
2018-05-25 16:27 ` Nick Desaulniers
2018-05-25 16:32 ` hpa
2018-05-25 16:46 ` Nick Desaulniers
2018-05-25 16:53 ` hpa
2018-05-25 17:31 ` Nick Desaulniers
2018-05-25 17:35 ` Tom Stellard
2018-05-25 17:49 ` Nick Desaulniers
2018-05-25 17:57 ` hpa
2018-05-25 17:59 ` Nick Desaulniers
2018-05-25 17:56 ` hpa
2018-05-25 20:36 ` Nick Desaulniers
2018-05-25 21:06 ` H. Peter Anvin
2018-05-25 22:38 ` Nick Desaulniers
2018-05-31 6:50 ` Nick Desaulniers
2018-06-01 17:13 ` Nick Desaulniers
2018-05-25 16:34 ` hpa
2018-05-25 8:24 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edccc580-5dac-a747-4326-53f401c8fab9@zytor.com \
--to=hpa@zytor.com \
--cc=astrachan@google.com \
--cc=ghackmann@google.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mka@google.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=tstellar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®