From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC8FC07E96 for ; Thu, 15 Jul 2021 08:08:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4D9E61362 for ; Thu, 15 Jul 2021 08:08:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239380AbhGOILs (ORCPT ); Thu, 15 Jul 2021 04:11:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58735 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237430AbhGOILq (ORCPT ); Thu, 15 Jul 2021 04:11:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626336533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NxNNLlcE8rIp3LWzPErIy9f88JTcquKQ1ZhKuQYRNy0=; b=MEDz6ib/O7mMGryWf9+FuXYMCT1xZVoB7bYjZ2yL9ezYobZ+JSzX34ojPeMV2qHLwYHxwq nNk/mXk87qlTcA2HqEfb0MgRNtOWHmCR281TBJqDBdJutB98zw1nZWpTYX/fNloAhfzm0X x/e2Vj6SPCABB1KWfoXtA5RtyMKqAh8= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-QSG2z-MPMma20wopkK2MOA-1; Thu, 15 Jul 2021 04:08:51 -0400 X-MC-Unique: QSG2z-MPMma20wopkK2MOA-1 Received: by mail-pf1-f198.google.com with SMTP id b10-20020a056a000ccab029032dc5f71f6aso3681916pfv.1 for ; Thu, 15 Jul 2021 01:08:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NxNNLlcE8rIp3LWzPErIy9f88JTcquKQ1ZhKuQYRNy0=; b=FZSg7ilGIzw0UH0fknDzoNejTRLZSxxeXb4o9QXvqcQyLxSp11wcszxqGd2MuyoYVO p0v2ZVwu+H49/QkXtXKgN8Y0duIbeR8caBFuXEym20sE5EqH3afVBO473TwQ+/Lmpofb EwaRGmMorye/z6/tq/5wLjE7kLT2z7oP9EgBnPOm79kANCoyMfywdy6iTc6UQEn/4GOr V60ees8XmiHKrl/6Ow36z/D0D/KwpCAhtsPtp1/2jZAQMxbVNoPBhIw4eDtHpYxvfkZL 1DVyf7mXqm0oCBZvzcR0ER/Cks0Jjz+jqhe/OvxHfLnY5c0Gp7ap4vU5SiaaKUWGGv1i 18fg== X-Gm-Message-State: AOAM532ZkJzhpi9vDSTi80v4qFqR7jpVr57hxHrfR0ti9VwISisgIbHA VdCANA/R2i4M0ArWtFfbigOsR2XRhuUy/ULb/kepCKkRdzZsWis47gC3p3MDNf8CxB/66XXwM1q FeuDthft05n/Zh4FwHH0c0MgAvos7DGlG+zlGtB3zzHhZACqTaMgxrEnMqL1FhCSWxOToguLvvR m3 X-Received: by 2002:a17:90a:bd8e:: with SMTP id z14mr3216901pjr.69.1626336530525; Thu, 15 Jul 2021 01:08:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjLSNkFoNf94fgb3Hf2PR/IplYN8HZXkYeF3grAaA1yAItdsZ2JSh18gI3qyBKyPG22b00Nw== X-Received: by 2002:a17:90a:bd8e:: with SMTP id z14mr3216870pjr.69.1626336530270; Thu, 15 Jul 2021 01:08:50 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x26sm5563647pfj.71.2021.07.15.01.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 01:08:49 -0700 (PDT) Subject: Re: [PATCH 2/4] vp_vdpa: Fix return value check for vdpa_alloc_device() To: Xie Yongji , mst@redhat.com, dan.carpenter@oracle.com Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210715080026.242-1-xieyongji@bytedance.com> <20210715080026.242-2-xieyongji@bytedance.com> From: Jason Wang Message-ID: Date: Thu, 15 Jul 2021 16:08:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715080026.242-2-xieyongji@bytedance.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/7/15 ÏÂÎç4:00, Xie Yongji дµÀ: > The vdpa_alloc_device() returns an error pointer upon > failure, not NULL. To handle the failure correctly, this > replaces NULL check with IS_ERR() check and propagate the > error upwards. > > Fixes: 64b9f64f80a6 ("vdpa: introduce virtio pci driver") > Reported-by: Dan Carpenter > Signed-off-by: Xie Yongji Acked-by: Jason Wang > --- > drivers/vdpa/virtio_pci/vp_vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c > index 7b4a6396c553..fe0527329857 100644 > --- a/drivers/vdpa/virtio_pci/vp_vdpa.c > +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c > @@ -436,9 +436,9 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa, > dev, &vp_vdpa_ops, NULL); > - if (vp_vdpa == NULL) { > + if (IS_ERR(vp_vdpa)) { > dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n"); > - return -ENOMEM; > + return PTR_ERR(vp_vdpa); > } > > mdev = &vp_vdpa->mdev;