From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9115F2522A1 for ; Mon, 18 Aug 2025 18:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755542158; cv=none; b=Et4W033XgSuy8slwLhlFzHf/w+ylHRASc8cMEb7xnKVOYJfETmpzFpmA4FCDF3rxA0udG9HigFRJW6SwxlxH0qD3Z494DOUfD+5vXn/8B2fDhHEGUn/u3zTrpaJi48p3YhYcP2MGngeS9j4gpLx91iP0NvmbT3+1BN333g02X6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755542158; c=relaxed/simple; bh=Rr8NoDrHGFkfU2Y7NB9dvXe3YofOu3AGh+O7rT1zNOc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SDkSAOyswSHNbAGfg3JJwye4++r+zgXihbNk4SZVtvqU2bEfif39qLqZRRN2dnOlWUMa6dlvuDPm/vpWk58citwV3AvMuuVGf04s3AL1x/G3CWX7siPaCTWFjsVv5olqRGXYYKU6x4LfVedXUltjV55f17SrCTep3g56rw2Wh+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PjbJ4SF5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PjbJ4SF5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57IEoFNo005494 for ; Mon, 18 Aug 2025 18:35:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rTw5fI/EzQLooVwdnSKD6j5ks0u5Tik6uLBbFQaZ44I=; b=PjbJ4SF5jsGRuPM8 lRiJxw1u113tX7wBLGTbQoy+3C6mIwKOJavCnyjt0KQfMN5t6oFVnQPOBVFoUtJQ EneaDEiUuLXqtzK5PTacSnK7X/Jr8zazde5n/R9zdJHoO0J3TXn/aWyG32UWilXy OEerE0aj750vPxvduioVB33IJ6wu32Xv0hGd25L/AAxffaXz9svr2Xyw7fYZ0mCI gZTWWjAwdv+B2UWYuVDb3HZcpSJkDNx/hvt7bjszyLHe2+Htog2zTVX1DJKuuthT Rl89WKPzZ9Ol2YfnDRgKI535EjA+i7w8peleWdhzNZHYS5+dWqKo66v+HOi3mb6f 1Zs8Pw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jgxte1yu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 18 Aug 2025 18:35:55 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-24457ef983fso88084925ad.0 for ; Mon, 18 Aug 2025 11:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755542155; x=1756146955; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rTw5fI/EzQLooVwdnSKD6j5ks0u5Tik6uLBbFQaZ44I=; b=Yyukd+BYYY7JikbPz7O4Pe2vggJrewG6G4+muTz5wizqTSmVp2Am18ZyUuFIxX8bH/ nTr6k7GZAW5/6nQSXy02ovuwnxbxOKFTy1BHLddKvj5L6wr8uctXcrduTMOjtMyXpbss pRUvZxCzI6Qr2eW1PAVSO1u/G7Sdj0WBiu9Bk/ws1XLQNfBmT4Js1KUdrUaWiyGG8oDO FggNJnMKaeyHGEorIyuiu7PnD5JDn4klX8iqQ9LlmeOulE3o7fTN/v9VcO5IkqPnYnGk hTMECeVH5bGaZeDGf4uq2KkfLjhkMvrPJxii1fvUr3RVwyO/UBYaCPDANfBzAYC5G7zD Av1A== X-Forwarded-Encrypted: i=1; AJvYcCXx1vB4YhbDf07o9qhszSe48cezzYit8j6IIBNRa9JpyzWXYonDp1Uzel33l+H0un20SVJeQznfH/XQK2s=@vger.kernel.org X-Gm-Message-State: AOJu0YxmgqQV7pHfmnt2JQTegiPZVnVQAdW4Sun4v9aTyEDYL8EpPY+g 8xgfCTHVtgJKkPMLjfvchfXIjb43otc5RAm2o10WDpZlFxOERQkwes3NgJ0TYh8d4DrZtzzc2Uo Rqu0NdKmBEytCJGTqNa2xs9AXM4R1uv5QM/sBGh68Fr/khlAVsaOlVKPNklCOoIcDInw= X-Gm-Gg: ASbGncvZQxgeIN7lF71KjlBIOCDw2NCNJHAZHVELQrRKGXpDYZc4ZfTccBnuJUNcByb g+ntCTUPZmYk6aXXdDv+MGLjd2hGT2kA1jcuRJF5aBln3LKic1bbdC/tqtL13bLrYSY+efm0VRK qClW2cTsVZ+h0lpGooVgKhRS5GEmuqtPjyjtS6+JawNlWRj5f2agf12kYAblIhZYHvdCL3Gnzf0 EQP3ABJbbdpQnDuQlQO/7A9l/nMgDuZfZslz4dhTJBeEIDzuCrJUYTU26ctE0fP7zXyTI+hZ1pS JtXhnld2QdgXyGUVLn6HZRuXIZxHKnCAkAJJiZoPYfyVQ6UR2YbJvPYMYATTPxWRQVrUihpgc6b jlhoWgYuJXtTJLsFPBKGY7g== X-Received: by 2002:a17:902:e883:b0:234:b743:c7a4 with SMTP id d9443c01a7336-2449d05e2e0mr6013375ad.38.1755542154900; Mon, 18 Aug 2025 11:35:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxDSynULb4PcFzZsBZRbHZngTsBrC0gfJFLCUyi3LdHcS+4FTyZjXC2laEfmopJd/tkxjqtA== X-Received: by 2002:a17:902:e883:b0:234:b743:c7a4 with SMTP id d9443c01a7336-2449d05e2e0mr6012665ad.38.1755542154422; Mon, 18 Aug 2025 11:35:54 -0700 (PDT) Received: from [10.134.71.99] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2446ca9d9a7sm87175925ad.23.2025.08.18.11.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 11:35:54 -0700 (PDT) Message-ID: Date: Mon, 18 Aug 2025 11:35:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] drm/msm/dpu: use drmm_writeback_connector_init() To: Dmitry Baryshkov , Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> <20250816-wb-drop-encoder-v2-4-f951de04f4f9@oss.qualcomm.com> Content-Language: en-US From: Jessica Zhang In-Reply-To: <20250816-wb-drop-encoder-v2-4-f951de04f4f9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UY4JlZsCeUjPImmtBRzrrrkzHH1K2ES4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyMCBTYWx0ZWRfX4/83RMzIf/ZM kXqsBnUmvx4x5MYSRadfAyZddSTuV81RRjISqEGwCRODfl7tuuJEyf0JRi8QVCBI/DUtmRIaKsP MDJDbB5Zjd0kKtrC5yh/75gF1gWiQcn9+6NBUEOasgWzV3jMKpfB9I3UTSUZMavRDxz8zHXG0K+ lxm8mlyRqSN+yyicDw0i4wMRps9qi2wT8i20zFH3jKa9nju8Nw1U3RbRnUjH3O4GyvdizRKuJNe XeBP7ZsH78tBfX+LhjxQ3FiovOo6FXp3MHqlAwtrBzeamEsQabuR0JC+0XvzRG5ecPNkLs5J7JX HmfuOHAs66Kzn6bnhckael/WPYMNYApWxXhUMThDmAc6n1kOop1XOD+a2nlJjT0MMXYGa1bcQIE WWev0Zp4 X-Proofpoint-GUID: UY4JlZsCeUjPImmtBRzrrrkzHH1K2ES4 X-Authority-Analysis: v=2.4 cv=V7B90fni c=1 sm=1 tr=0 ts=68a3728c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=hy87YkSEx0gxqBhA-1kA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-18_05,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160020 On 8/16/2025 8:19 AM, Dmitry Baryshkov wrote: > Use drmm_plain_encoder_alloc() to allocate simple encoder and > drmm_writeback_connector_init() in order to initialize writeback > connector instance. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang Thanks, Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > index 8ff496082902b1ee713e806140f39b4730ed256a..cd73468e369a93c50303db2a7d4499bcb17be5d1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c > @@ -80,7 +80,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector, > static const struct drm_connector_funcs dpu_wb_conn_funcs = { > .reset = drm_atomic_helper_connector_reset, > .fill_modes = drm_helper_probe_single_connector_modes, > - .destroy = drm_connector_cleanup, > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > @@ -131,12 +130,9 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, > > drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs); > > - /* DPU initializes the encoder and sets it up completely for writeback > - * cases and hence should use the new API drm_writeback_connector_init_with_encoder > - * to initialize the writeback connector > - */ > - rc = drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base, enc, > - &dpu_wb_conn_funcs, format_list, num_formats); > + rc = drmm_writeback_connector_init(dev, &dpu_wb_conn->base, > + &dpu_wb_conn_funcs, enc, > + format_list, num_formats); > > if (!rc) > dpu_wb_conn->wb_enc = enc; >