From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68747C433DB for ; Fri, 12 Feb 2021 13:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23F5B64DE3 for ; Fri, 12 Feb 2021 13:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbhBLNKW (ORCPT ); Fri, 12 Feb 2021 08:10:22 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35142 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbhBLMto (ORCPT ); Fri, 12 Feb 2021 07:49:44 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 11CCmZwY071475; Fri, 12 Feb 2021 06:48:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1613134115; bh=SFCHRJEZKuC8tAGhsa/pKFsCkhYCR9NZsOPbGEoRRKU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=cCtjL3XPG0iph9XzEB20haUA3QdIq3oGP9G1scv101jW+MRMWO8Hitk3qwl6f0fS+ bJG/4KPV7Mv/RPc8lp3jRxOP7L8QxNbiORUx0kuqBGLbbms5iaD+OSM+1yq1Ee3T+I drl514DiBkNuqt18k8gvM92JdFuYehcNpftl/nIk= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 11CCmZuq071363 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Feb 2021 06:48:35 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 12 Feb 2021 06:48:35 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 12 Feb 2021 06:48:35 -0600 Received: from [10.250.234.16] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 11CCmVXk037765; Fri, 12 Feb 2021 06:48:32 -0600 Subject: Re: [PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc To: Wei Yongjun , Hulk Robot , Jon Mason , Dave Jiang , Allen Hubbe , Lorenzo Pieralisi CC: , , Kishon Vijay Abraham I References: <20210210075345.1096001-1-weiyongjun1@huawei.com> From: Kishon Vijay Abraham I Message-ID: Date: Fri, 12 Feb 2021 18:18:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210210075345.1096001-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/21 1:23 pm, Wei Yongjun wrote: > It's not necessary to free memory allocated with devm_kzalloc > and using kfree leads to a double free. > > Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent Bridge") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/ntb/hw/epf/ntb_hw_epf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c > index 2cccb7dff5dd..b019755e4e21 100644 > --- a/drivers/ntb/hw/epf/ntb_hw_epf.c > +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c > @@ -723,7 +723,6 @@ static void ntb_epf_pci_remove(struct pci_dev *pdev) > ntb_unregister_device(&ndev->ntb); > ntb_epf_cleanup_isr(ndev); > ntb_epf_deinit_pci(ndev); > - kfree(ndev); > } Reviewed-by: Kishon Vijay Abraham I > > static const struct ntb_epf_data j721e_data = { >