From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>,
zev@bewilderbeest.net, Liam Girdwood <lgirdwood@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4] regulator (max5970): Add hwmon support
Date: Tue, 26 Sep 2023 12:43:54 -0700 [thread overview]
Message-ID: <edebb3a6-a116-49dd-9571-3f56a618117f@roeck-us.net> (raw)
In-Reply-To: <ZRL4j32syAhYVu0y@finisterre.sirena.org.uk>
On Tue, Sep 26, 2023 at 05:28:15PM +0200, Mark Brown wrote:
> On Tue, Sep 19, 2023 at 07:48:23AM +0200, Naresh Solanki wrote:
> > Utilize the integrated 10-bit ADC in Max5970/Max5978 to enable voltage
> > and current monitoring. This feature is seamlessly integrated through
> > the hwmon subsystem.
>
> Guenter, are you OK with the hwmon side of this?
Sorry, I lost track. Not really; see my response to the patch.
I think the memory allocation in that driver is a bit too complicated.
It trades simplicity for minor memory savings, and even those savings
are questionable. It would have been much easier and simpler to just
add a two-element regulator_dev array to struct max5970_regulator
and live with the "lost" memory if only one of them is used. I suspect
that would have consumed less memory and code overall.
Guenter
next prev parent reply other threads:[~2023-09-26 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 5:48 Naresh Solanki
2023-09-26 15:28 ` Mark Brown
2023-09-26 19:43 ` Guenter Roeck [this message]
2023-09-26 19:36 ` Guenter Roeck
2023-10-04 8:22 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edebb3a6-a116-49dd-9571-3f56a618117f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®