From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B9B21DEFC5 for ; Wed, 29 Jan 2025 16:36:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738168580; cv=none; b=serhuaFjxNFLxB5c8jW7t9t8yUaAhto3wVSeOGp2Z273lCy/pe3ojwzDyhTv1PaUL08yYWDCpO7XPtLHiu14KKJFsTZe4hod9wkChtfDCr7qG9wIihMYWQqDRHsR2zmRG80vyc/zGsgH9JZzCI1JXPD6DqwqkP6+Ovc6Wft7CsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738168580; c=relaxed/simple; bh=b7h8Cl/LN6h3JNUZuYjA7Ocp1zmHYwfk1VDVH0r5zUA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FZ1IWz8FI5hvGOvQIUoZk+u5tMrUrTIV8+38BHQ6pOEUBvK5HkOnGupgdUAmRCTJ5YUU0ZwX6kCQNtMjWThqyU5JWp6uiOYTuspEUy5JOZlzCV3TH+7hU8pWyZNutNjJkWqklomYy/favYxyfoxbXuipyXDwi9yCZV7uMGQV/mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NTzZ/c4W; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NTzZ/c4W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738168578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEisJ5rTfwNR5GChQhUaI/o22gNghqV/PWwRhbw5Gmg=; b=NTzZ/c4W0G+Qlbnt7l7XMOY8ZWgxrXGe/r703/yhl9pmx56bF5gK2ITs/sHzZ/tW9V9ppN 9QaO0LRS+WOWDtAI2QYmdr30HCed2z7aiKu5e9ViWkqMwrT1Q3Lk+kE4CEEBxVuFhGhCQh 2ymqg1hPYkg7mORbi7B/bEWI+B6vHU4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-ibxxlRl0MWuyvWDBT9JgoQ-1; Wed, 29 Jan 2025 11:36:16 -0500 X-MC-Unique: ibxxlRl0MWuyvWDBT9JgoQ-1 X-Mimecast-MFC-AGG-ID: ibxxlRl0MWuyvWDBT9JgoQ Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ab68fbe53a4so523497766b.2 for ; Wed, 29 Jan 2025 08:36:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738168576; x=1738773376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aEisJ5rTfwNR5GChQhUaI/o22gNghqV/PWwRhbw5Gmg=; b=rW8ANCSpglt4RTwGxnJC8yfz1IyX24Ec5x4BMCbDeC2gVhh9FZiFnmGSlWhOvXfXAg 6uGHS+aLH1vp65IdcxJkg5O+vIYaighXCzxbhkhze66LHGvehcEFxWkNlaR/JuNwsfI9 bW//Wz6FPD7vKZtQm7DcncMf4Pr6oitqph9VECLKFeGYUUBx1FICYrGOdwZzWXkIK4XK FfEGjoOFZLZDnrLBUEy0JV1O1F5919oa2AtKvZ3iQmomtWqQayyU7I72CWfqlKu5pzs8 5/dSWYU7adHkkUs9ZG46fP0oU2l94Gfbxk53bJ0bnwHSej/2c2MiB0eg+C0Z9xa3Doyr FQiQ== X-Forwarded-Encrypted: i=1; AJvYcCWiLARg2E6eBuqh/+taXSox8FzA99FcOG3WKLDG/SGxAHGQk/m2FJyd1W/oxUFb3n1nPGLFFLTkl6TyuNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwXvwKXwQgTUEWNWvyzyvqfwTcKJNkE5CGNywe8HirFCgAFb69W wAhxnXV+1f9YvKdgNgBB9U6ZXPaShsfjknN/hTnwhXKLwOoMY7px1zjWrZoycONcPVUGBhqvhkX j3Udt/uCUIcA+TyaS6RzzN2gG8HqVwuUCnn0jXysY7u2kOFhg4i6x4dYLyc/izg== X-Gm-Gg: ASbGnctCVw11DQbJL+pqWB9WBwhsq5Qc3OyWttyvZ7efMRq3avRsfZx1zUIfxTf7O62 jqpA1S6YyC5Y8wOsixC7nSBZSU26hW0zOIhio0GdcyDQM0nHRiIvM0GdrcDHbV3ffMrqHYleYWO mjMVC/TAPPDOEm2WFRAI4pL6geaAeVZAFzIhj2L1Y0qhFntNHNo6etJPpa4+ytO60UdYr++WI2D jNk0aKGS1N603BOUXYMT1gIWOh2ngmEv58FFV7+KZStT4yRD7OBIo74Gk2Pm1yzLkRbjxkxkFFZ DRD/PmyBrSI/5OoVNfMtPz6ztfQotHHjLZls4x1k/VuvfGMA0MJFeX2slx1+3fs/9W9ybEhA6Kt voc0qJHGtLYJDFwiBC+/kzvkudWlF6+/Y3/pJMuC+dEEXLZiCwQblTNM= X-Received: by 2002:a17:906:46c2:b0:ab6:d418:6871 with SMTP id a640c23a62f3a-ab6d41868c7mr260956466b.29.1738168575639; Wed, 29 Jan 2025 08:36:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IESsZEm0ot02c3Vk8UoPW5/JpnU1L5eHCz9cBs5bHvzy7OwDYLbHKvvMKGp9HvNcm2sBEjluA== X-Received: by 2002:a17:906:46c2:b0:ab6:d418:6871 with SMTP id a640c23a62f3a-ab6d41868c7mr260953166b.29.1738168575128; Wed, 29 Jan 2025 08:36:15 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760fbf4esm990182466b.155.2025.01.29.08.36.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 08:36:14 -0800 (PST) Message-ID: Date: Wed, 29 Jan 2025 17:36:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_chtdc_ti: Drop unneeded assignment for cache_type To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Lee Jones References: <20250129152823.1802273-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250129152823.1802273-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 29-Jan-25 4:28 PM, Andy Shevchenko wrote: > REGCACHE_NONE is the default type of the cache when not provided. > Drop unneeded explicit assignment to it. > > Note, it's defined to 0, and if ever be redefined, it will break > literally a lot of the drivers, so it very unlikely to happen. > > Signed-off-by: Andy Shevchenko Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/mfd/intel_soc_pmic_chtdc_ti.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mfd/intel_soc_pmic_chtdc_ti.c b/drivers/mfd/intel_soc_pmic_chtdc_ti.c > index 8582ae65a802..4c1a68c9f575 100644 > --- a/drivers/mfd/intel_soc_pmic_chtdc_ti.c > +++ b/drivers/mfd/intel_soc_pmic_chtdc_ti.c > @@ -82,7 +82,6 @@ static const struct regmap_config chtdc_ti_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > .max_register = 0xff, > - .cache_type = REGCACHE_NONE, > }; > > static const struct regmap_irq chtdc_ti_irqs[] = {