From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755796AbaCPU3E (ORCPT ); Sun, 16 Mar 2014 16:29:04 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:40187 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253AbaCPU3A (ORCPT ); Sun, 16 Mar 2014 16:29:00 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20140316191639.GJ3106@piout.net> References: <1394040940-18246-1-git-send-email-alexandre.belloni@free-electrons.com> <1394040940-18246-5-git-send-email-alexandre.belloni@free-electrons.com> <5325EA96.9000907@kernel.org> <20140316191639.GJ3106@piout.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR From: Jonathan Cameron Date: Sun, 16 Mar 2014 20:28:54 +0000 To: Alexandre Belloni CC: Nicolas Ferre , Dmitry Torokhov , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Maxime Ripard , Gregory Clement Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 16, 2014 7:16:39 PM GMT+00:00, Alexandre Belloni wrote: >On 16/03/2014 at 18:16:54 +0000, Jonathan Cameron wrote : >> On 05/03/14 17:35, Alexandre Belloni wrote: >> >Old ADCs, as present on the sam9rl and the sam9g45 don't have a TSMR >register >> >and the touchscreen support should be handled differently. >> > >> >Signed-off-by: Alexandre Belloni > >> One comment inline about handling of devices where the platform data >doesn't >> include the touchscreen type. I'd expect zero to be the current >default >> rather than NONE... >> >diff --git a/include/linux/platform_data/at91_adc.h >b/include/linux/platform_data/at91_adc.h >> >index fcf73879dbfe..7819fc787731 100644 >> >--- a/include/linux/platform_data/at91_adc.h >> >+++ b/include/linux/platform_data/at91_adc.h >> >@@ -7,6 +7,12 @@ >> > #ifndef _AT91_ADC_H_ >> > #define _AT91_ADC_H_ >> > >> >+enum atmel_adc_ts_type { >> This means that the default for existing touch screens (where the >platform >> data won't include setting this value) will be none. Is that >correct? >> >+ ATMEL_ADC_TOUCHSCREEN_NONE = 0, >> >+ ATMEL_ADC_TOUCHSCREEN_4WIRE = 4, >> >+ ATMEL_ADC_TOUCHSCREEN_5WIRE = 5, >> >+}; >> >+ > >This is actually just a snippet that I moved from at91_adc.c to >at91_adc.h. I followed the current behavior. Until now, using the >touchscreen was only supported through device tree and touchscreen >handling was not activated unless the atmel,adc-ts-wires property is >present. I guess this is the sane way to go because when you use the >touchscreen, you lose the triggers. Ah. Thanks for clearing that up. I missed that it previously existed entirely.. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.