From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 160E6247DE1 for ; Fri, 8 Aug 2025 07:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754639127; cv=none; b=Xsf3NrQ/NzHjU2X2/fVVtEXIpyGaOX4k4A6ZrUq4ZwW+FKSzBJdsc/HT5naSm1xJnL7Om8yZwdp/DRtW8inp6Cd2PSblzYoTxqXgqEzLMuVK342G8P1izRuPGPgDH36BrQhjkTMLUtaBUjqgJ4s9RVwZxxbPWrBSk9f1xe5xJps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754639127; c=relaxed/simple; bh=URSjpcRLAvp9iKHGYqH/ubCxh6/KqTTZW+PFtIU6CKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hFDZuESNiu8M1VzOmvxg+UwjGFsE7ZBKEkUjvmmFutJSvHBu4SYIalHlKijb3gHLAoQF+iy45Ss066fQhgnOgyp+9tarqFWgh2mibBRynOGB5+dEhfLQg67bWSizFJjhx7Ldcv7G2byyIbTfmc0xc5+nPGmDQVwJjd5utXLmiec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VlWTFjuz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VlWTFjuz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754639124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N3k83UvrhuN2kOP3CJmGEqFJiCwkFeONC0G32psqYOY=; b=VlWTFjuzFUQzlU4k79l2a5oPUmmaIaTGgVBKDnXOtqdmt/5X2nAmxrq94tFr7Ovx4TbRSW IIt7RaNEWKpDCl2owy/mstzFsXvEVQ+xEOC/ByQrYUJAMoGqoiH43FkaFpDmsfFqMSaNpp 47rrWZI3qTJHDKIgB/sEv66IuRIp5GQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-m1b_9jiVOCOz9ey6Nx-Ysw-1; Fri, 08 Aug 2025 03:45:19 -0400 X-MC-Unique: m1b_9jiVOCOz9ey6Nx-Ysw-1 X-Mimecast-MFC-AGG-ID: m1b_9jiVOCOz9ey6Nx-Ysw_1754639118 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0906D1956086; Fri, 8 Aug 2025 07:45:18 +0000 (UTC) Received: from [10.44.22.5] (unknown [10.44.22.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B809A1954196; Fri, 8 Aug 2025 07:45:13 +0000 (UTC) Message-ID: Date: Fri, 8 Aug 2025 09:45:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 5/7] vduse: add vq group asid support To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= , "Michael S . Tsirkin" Cc: Cindy Lu , Yongji Xie , Stefano Garzarella , virtualization@lists.linux.dev, Laurent Vivier , linux-kernel@vger.kernel.org, Xuan Zhuo , jasowang@redhat.com, Maxime Coquelin References: <20250807115752.1663383-1-eperezma@redhat.com> <20250807115752.1663383-6-eperezma@redhat.com> Content-Language: en-US From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: <20250807115752.1663383-6-eperezma@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 8/7/25 1:57 PM, Eugenio Pérez wrote: > diff --git a/include/uapi/linux/vduse.h b/include/uapi/linux/vduse.h > index b4b139dc76bb..d300fd5f867f 100644 > --- a/include/uapi/linux/vduse.h > +++ b/include/uapi/linux/vduse.h > @@ -47,7 +47,8 @@ struct vduse_dev_config { > __u32 vq_num; > __u32 vq_align; > __u32 ngroups; /* if VDUSE_API_VERSION >= 1 */ > - __u32 reserved[12]; > + __u32 nas; /* if VDUSE_API_VERSION >= 1 */ > + __u32 reserved[11]; > __u32 config_size; > __u8 config[]; > }; > @@ -82,6 +83,17 @@ struct vduse_iotlb_entry { > __u8 perm; > }; > > +struct vduse_iotlb_entry_v2 { > + __u64 offset; > + __u64 start; > + __u64 last; > +#define VDUSE_ACCESS_RO 0x1 > +#define VDUSE_ACCESS_WO 0x2 > +#define VDUSE_ACCESS_RW 0x3 > + __u8 perm; > + __u32 asid; > +}; > + > /* > * Find the first IOVA region that overlaps with the range [start, last] > * and return the corresponding file descriptor. Return -EINVAL means the > @@ -172,6 +184,16 @@ struct vduse_vq_group { > __u32 num; > }; > > +/** > + * struct vduse_vq_group - virtqueue group > + @ @group: Index of the virtqueue group > + * @asid: Address space ID of the group > + */ > +struct vduse_vq_group_asid { > + __u32 group; > + __u32 asid; > +}; > + > /** > * struct vduse_vq_info - information of a virtqueue > * @index: virtqueue index > @@ -232,6 +254,7 @@ struct vduse_vq_eventfd { > * @uaddr: start address of userspace memory, it must be aligned to page size > * @iova: start of the IOVA region > * @size: size of the IOVA region > + * @asid: Address space ID of the IOVA region > * @reserved: for future use, needs to be initialized to zero > * > * Structure used by VDUSE_IOTLB_REG_UMEM and VDUSE_IOTLB_DEREG_UMEM > @@ -241,7 +264,8 @@ struct vduse_iova_umem { > __u64 uaddr; > __u64 iova; > __u64 size; > - __u64 reserved[3]; > + __u32 asid; > + __u32 reserved[5]; > }; > > /* Register userspace memory for IOVA regions */ > @@ -265,7 +289,8 @@ struct vduse_iova_info { > __u64 last; > #define VDUSE_IOVA_CAP_UMEM (1 << 0) > __u64 capability; > - __u64 reserved[3]; > + __u32 asid; /* Only if device API version >= 1 */ > + __u32 reserved[5]; > }; > > /* > @@ -289,6 +314,7 @@ enum vduse_req_type { > VDUSE_UPDATE_IOTLB, > VDUSE_GET_VQ_GROUP, > VDUSE_GET_VRING_DESC_GROUP, > + VDUSE_SET_VQ_GROUP_ASID, > }; > > /** > @@ -344,6 +370,8 @@ struct vduse_dev_request { > struct vduse_dev_status s; > struct vduse_iova_range iova; > struct vduse_vq_group vq_group; /* Only if vduse api version >= 1 */ > + /* Only if vduse api version >= 1 */ > + struct vduse_vq_group_asid vq_group_asid; > __u32 padding[32]; I think you need to update padding size here. > }; > }; > @@ -367,6 +395,8 @@ struct vduse_dev_response { > union { > struct vduse_vq_state vq_state; > struct vduse_vq_group vq_group; /* Only if vduse api version >= 1 */ > + /* Only if vduse api version >= 1 */ > + struct vduse_vq_group_asid vq_group_asid; > __u32 padding[32]; > }; > }; Same Regards, Maxime