From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61C5C1A38F9 for ; Fri, 12 Jun 2026 04:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781239096; cv=none; b=C5nHCSbnBbDW1+xuDzXVA215Sktkj20eiQSA8o7us9ulRw10elS1pTKuCdq2gYseqXGcpfTdW/ws/8t2OKCl/KbaF6YuhHEHuehjllVqQKlt9fBTIC17NnGOExKpf0AkWTrgE8meS1p/5UrK8kSPWy2VxEPvqoT26ctwoYhsABo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781239096; c=relaxed/simple; bh=LU2+bXF8Md1mevsWyReMzv5gzCRLILXqgYhXQu5nCvU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p2eorTQuTK16ozcDy+4HTWEetnqhGA57lSuwz2IZ6GhFMwM0o4n2Kf1rhcexCSQGwUlhdi7kVAIzN97Ck0cHpxYpYqsn2rdgqbM9je/mgB7NjgxZQgznXntdbApk/+aShVJhPnQ7QiO7qlhM1QturrpfsuVjHU0nVO7qxy7Y/aM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FJ62EPl/; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FJ62EPl/" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-396779b9a7fso4439221fa.3 for ; Thu, 11 Jun 2026 21:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781239094; x=1781843894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3ndCIHkzQr8X/wAr7SR3f5wJs+kfHWoXWyvPJBY/9F4=; b=FJ62EPl/hGlnDPj0BodsXD0KmG+Dq7Rh5I2P2jPelEdL4xMt0628lAdwBW4FA+7aKn zco/eFYQsDD52bRKpAiNDRjMO2+DlEb5inl+cOdhgCyTE09fTd/8ObYysgPnOTfYKm6H Dhfgamait7nBq4Mcw57lVvLudzyz7Bm8EkEPj/hmFV+eeP/PooyCF3Ji9i0iUX8Y96pJ +KXTuMezFmsPmiTomlCoMqRhV3h5IhsEkbKSC0gxhiOkN3jgP1vnr9Kt7p1YIFjUYgB+ DMMz9eJ7SI77p9BkObZNNswYu8LNrHaOXuUKEp8wVTw/sltKeJKgIVqzo7cYJlmVzlSu N71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781239094; x=1781843894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ndCIHkzQr8X/wAr7SR3f5wJs+kfHWoXWyvPJBY/9F4=; b=tU9kew9mmWCabdDCc4TLxreTV8gFNQr/zK493YLpyahYlCeG/M2AzQU9td6Yp6okEc 6B00TL8y60557vOGTaOoQYbs9ycE9Mygt8Cob5/CvBrUe47wtBIc8ef7G724RgVyNDGx YIeFZw+83xzcdhf9f7FSK5LbluI3xVPmDa5GIlx57xwIiSkbbrIiohhrcDFfLKRPszQE uz6ZTLkvAeMONTgGVGluhJgfeHk3/nhOlZNXkjE1nLl3Nvxd0/gEGDDvAz4FtmifzDHZ 3tXXyxy0ObDXRDD0/mcHyUQKrvbyPC+CDu+57/w4/Dy+WHshrYz7+/bAL7hvx715VNRT blVQ== X-Forwarded-Encrypted: i=1; AFNElJ8RkYdadiDDyexkRN2v5arqq61Vf5gOTKc5jjDKXo6U6A5Gbv5I8Gz1tx4u8cjuflB1Nmgg4/QVhSMHgCE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxysr4rwtnKhRgV1kRUBwOuezM0yhhTbu0Rl400tIaT3R9W3i3z ncAdSVv4u/6qUQsDU8tH/8GLPjEf9MO+cuj25FzSfwOYO2MJBplJ6ZMR X-Gm-Gg: Acq92OHfz+RmNXOvJBTdAlRGyRItip1U2yr3xOWKqTEHaSkCIb+xawfl7aCLs0Ovbxd ha6qBw4kjYYk6aq8aALBEViIk9oPZvdg4G1ic8AJEkoGrvRGPYOUZvxiDVnDKcq3vEvBL3enfSM 9wQf9R1GtrjJjv9iqzUyQvqyReql/jnDkHEs/KB2Qyo7x7ndxBP6BWSaEaix7QfsiaE/8LAdgWn Ono6okAzmrcr7Qfz2G0965GROkT9ybbZ1I/XaFm0kydW0Jo4RQgOgS3mL6n318yzoGf3hu/Tn8V Ygs9dveIXeZHhV5gnUth7VpLlyC+HgSRLB0U/V4lrtHJfKWboR5495h+mXtKgfv6dWSEsP3SJW6 v8HXU7HQxulR0fPcFlSDCFGzK2ep9Pi6TIjpBqrinfDWD5IGA9Rvzz7xlIqehMfEPLZyxwSJjiS VU2SQH/hl1EzXYDhvLCgg6gaq5WLGoC28etjZO5Bg1ROeh0iKptayvS1TucQDCrAqBTZipcK4ex RE1wKp9 X-Received: by 2002:a05:6512:10c8:b0:5aa:6c2f:2a36 with SMTP id 2adb3069b0e04-5ad2db26f06mr401194e87.4.1781239093337; Thu, 11 Jun 2026 21:38:13 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e170386sm186498e87.30.2026.06.11.21.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 21:38:12 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 07:38:11 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys To: Dmitry Torokhov , Lee Jones Cc: Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/06/2026 18:48, Dmitry Torokhov wrote: > Now that gpio-keys can use platform resources to identify interrupts > assigned to buttons we can convert ROHM power buttons to use software > nodes and device properties for configuration, removing the need to use > platform data. > > Signed-off-by: Dmitry Torokhov > ---> Changes in v5: > Addressed Lee's comments: > - moved static constants out of function to module level > - added #defines for nodes' indexes > - adjusted error message > - renamed "error" to "ret" > - dropped unneeded comments > - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes-v4-0-ffeb5b0c4774@gmail.com I think I did already review these? Is there a reason my tags were dropped? Yours, -- Matti