mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Praveen Kumar <kpraveen.lkml@gmail.com>,
	outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, forest@alittletooquiet.net,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 2/7] staging: vt6655: Use incrementation in `idx`
Date: Mon, 01 Nov 2021 09:47:07 +0000	[thread overview]
Message-ID: <edf5d0899f13414b2e5c1a6f1b6da08291e26e95.camel@gmail.com> (raw)
In-Reply-To: <edfd74c7-9b6d-f8f5-65c4-c1bae3015247@gmail.com>

Hi Praveen,

On Fri, 2021-10-29 at 21:11 +0530, Praveen Kumar wrote:
> However, as mentioned in previous patch, we can also make *i* as
> unsigned short and that should IMO remove the requirement of cast.

I agree, it should remove the cast but I think I'll leave `idx` as it
is.

> But again, this works as well. I'm fine with either. Thanks and sorry
> for the confusion.

No worries, thanks for looking at my changes. It's good to double check
everything :)


Thanks,
Karolina


  reply	other threads:[~2021-11-01 10:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 10:35 [PATCH 0/7] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn` Karolina Drobnik
2021-10-28 10:35 ` [PATCH 1/7] staging: vt6655: Introduce `idx` temporary variable Karolina Drobnik
2021-10-29 14:47   ` [Outreachy kernel] " Praveen Kumar
2021-11-04 12:05   ` Dan Carpenter
2021-10-28 10:35 ` [PATCH 2/7] staging: vt6655: Use incrementation in `idx` Karolina Drobnik
2021-10-29 14:56   ` [Outreachy kernel] " Praveen Kumar
2021-10-29 15:41     ` Praveen Kumar
2021-11-01  9:47       ` Karolina Drobnik [this message]
2021-10-28 10:35 ` [PATCH 3/7] staging: vt6655: Remove unused `i` increments Karolina Drobnik
2021-10-28 10:35 ` [PATCH 4/7] staging: vt6655: Introduce `data` temporary variable Karolina Drobnik
2021-10-28 11:21   ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-28 11:32     ` Julia Lawall
2021-10-28 11:48       ` Fabio M. De Francesco
2021-10-28 14:31         ` Karolina Drobnik
2021-10-28 14:40           ` Julia Lawall
2021-10-28 10:35 ` [PATCH 5/7] staging: vt6655: Rewrite conditional in AL7320 initialization Karolina Drobnik
2021-10-28 12:36   ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-28 13:06     ` Julia Lawall
2021-10-28 14:35       ` Karolina Drobnik
2021-10-28 15:36         ` Fabio M. De Francesco
2021-10-28 10:35 ` [PATCH 6/7] staging: vt6655: Rename `RFvWriteWakeProgSyn` function Karolina Drobnik
2021-10-28 10:35 ` [PATCH 7/7] staging: vt6655: Update comment for `rf_write_wake_prog_syn` Karolina Drobnik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edf5d0899f13414b2e5c1a6f1b6da08291e26e95.camel@gmail.com \
    --to=karolinadrobnik@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kpraveen.lkml@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®