mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Bliss <abliss@google.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
	Russell King <rmk@flint.arm.linux.org.uk>,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: tty_tiocmset() masks out TIOCM_RI and TIOCM_CD, which breaks  rfcomm
Date: Wed, 21 Jan 2009 10:13:02 -0800	[thread overview]
Message-ID: <ee007d8e0901211013i7a5b3bc9w23c9c94e88296c0@mail.gmail.com> (raw)
In-Reply-To: <20090121153229.4a11cb8e@lxorguk.ukuu.org.uk>

Hi, Alan.  Thanks for the reply.

On Wed, Jan 21, 2009 at 07:32, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> I would have expected the driver to be remapping RI/CD just as it does
> for the DTR<->DSR RTS<->CTS cable switch around.
>
> It's certainly possible to fix it, but that would need a double check on
> the existing drivers and that passing new suprise bits won't do any harm.
> The real question is what should the right behaviour be - and to me that
> seems to be to logically flip all the lines not just DTR/DSR RTS/CTS

What would you expect the driver to map RI and CD to?  I don't think
there are DTE->DCE signals that correspond to RI and CD.  Possibly
OUT1 and OUT2 could be used, since I don't think these are used
anywhere else in rfcomm, but this might be unintuitive.  I'll let
Marcel address that idea.

--Adam

      reply	other threads:[~2009-01-21 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 23:24 Adam Bliss
2009-01-21 15:32 ` Alan Cox
2009-01-21 18:13   ` Adam Bliss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee007d8e0901211013i7a5b3bc9w23c9c94e88296c0@mail.gmail.com \
    --to=abliss@google.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rmk@flint.arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®