From: Like Xu <like.xu.linux@gmail.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Like Xu <likexu@tencent.com>
Subject: Re: [PATCH v3.1 0/4] KVM: x86: Use static calls to reduce kvm_pmu_ops overhead
Date: Wed, 30 Mar 2022 23:02:54 +0800 [thread overview]
Message-ID: <ee0892bb-ba1e-251d-8e19-ac26b4c0799d@gmail.com> (raw)
In-Reply-To: <20220329235054.3534728-1-seanjc@google.com>
On 30/3/2022 7:50 am, Sean Christopherson wrote:
> This is a minor iteration on Like's v3 to allow kvm_pmu_ops (the global
> variable, not the struct) be static. I ran the PMU unit tests and compiled,
> but otherwise it's untested. Strongly recommend waiting for Like to give
> a thumbs up before applying :-)
Uh, thank you for picking up this optimization and it passes my test cases.
>
> [*] https://lore.kernel.org/all/20220307115920.51099-1-likexu@tencent.com
>
> Like Xu (4):
> KVM: x86: Move kvm_ops_static_call_update() to x86.c
> KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection
> KVM: x86: Move .pmu_ops to kvm_x86_init_ops and tag as __initdata
> KVM: x86: Use static calls to reduce kvm_pmu_ops overhead
>
> arch/x86/include/asm/kvm-x86-pmu-ops.h | 31 ++++++++++++
> arch/x86/include/asm/kvm_host.h | 17 +------
> arch/x86/kvm/pmu.c | 66 ++++++++++++++++++--------
> arch/x86/kvm/pmu.h | 7 +--
> arch/x86/kvm/svm/pmu.c | 2 +-
> arch/x86/kvm/svm/svm.c | 2 +-
> arch/x86/kvm/vmx/pmu_intel.c | 2 +-
> arch/x86/kvm/vmx/vmx.c | 2 +-
> arch/x86/kvm/x86.c | 21 +++++++-
> 9 files changed, 102 insertions(+), 48 deletions(-)
> create mode 100644 arch/x86/include/asm/kvm-x86-pmu-ops.h
>
>
> base-commit: 19164ad08bf668bca4f4bfbaacaa0a47c1b737a6
next prev parent reply other threads:[~2022-03-30 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 23:50 Sean Christopherson
2022-03-29 23:50 ` [PATCH v3.1 1/4] KVM: x86: Move kvm_ops_static_call_update() to x86.c Sean Christopherson
2022-03-29 23:50 ` [PATCH v3.1 2/4] KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection Sean Christopherson
2022-03-29 23:50 ` [PATCH v3.1 3/4] KVM: x86: Move .pmu_ops to kvm_x86_init_ops and tag as __initdata Sean Christopherson
2022-03-29 23:50 ` [PATCH v3.1 4/4] KVM: x86: Use static calls to reduce kvm_pmu_ops overhead Sean Christopherson
2022-03-30 15:02 ` Like Xu [this message]
2022-04-08 16:49 ` [PATCH v3.1 0/4] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee0892bb-ba1e-251d-8e19-ac26b4c0799d@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®