From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CFEB1E50B for ; Sun, 29 Dec 2024 12:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735476082; cv=none; b=Khirqm33szW8Mli/TbCW3nAJXtpHwnE/wmWGLkgP1j/rciWUgcY74JKFjPEhDZUzu+3zIzgfaJO/8cyAyqH6Io7IGbZzzQy1bvyM4PdgKUkKF2aF2fx1kQZKXwM35T0Vxo5g9OWKdwdqWAg9AGEqDb4EkaE3Z1GnYCNo85fQGOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735476082; c=relaxed/simple; bh=J008uRuxTsGiy0lr0FzeapnwTyisendOaENS8IHfagE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ffDMCnyd9+Q4s2b6sPqiHiaw9nmeqJ2g0XdOIqa+P0B0Mx1WhvkxCVp0Dd2Q+5G5wopzzX9G1mbKbKE++Iyc+NfoL3V8G/OgE/i5198r39k8erqD9Gk7725ZO9RPAzJefmweA8gaFlNrPcuD9WdfxxCFcZtlq3UG9PPhXMTFcMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=colorfullife.com; spf=pass smtp.mailfrom=colorfullife.com; dkim=pass (2048-bit key) header.d=colorfullife-com.20230601.gappssmtp.com header.i=@colorfullife-com.20230601.gappssmtp.com header.b=Y5sep/Kk; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=colorfullife.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=colorfullife.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=colorfullife-com.20230601.gappssmtp.com header.i=@colorfullife-com.20230601.gappssmtp.com header.b="Y5sep/Kk" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aa692211331so1620624966b.1 for ; Sun, 29 Dec 2024 04:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=colorfullife-com.20230601.gappssmtp.com; s=20230601; t=1735476079; x=1736080879; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/gUIxBYTNdKmO7h8yq3Oe9LTVRomBNQ7bx60VPAPgIs=; b=Y5sep/KkzeOYtgvbDXzgcp/lOEhVxN+IjHU7QA7l2LCAvOv491NDWtPXUPaIJtAVnU uGq0d7uZOcelE78AvkgxWIV5TtMykavYSd8rVKpEGl3RG8deFYUDf8ZP4eWbkBFbyeiC 94jQqO3EYnOUXWwrKu4VwExV0Dis4tK8eDjb5HsiUT9uASo4W4n+flt70SUuVbLIey+2 3qWHRa25vHOJk4vZ9bJW+s3DRlmtUfCVwkM/pbN/0F4NULcbZ0q8avhjy9QO8HTn7OAf /ua1TZZjVE6OqjS80RReey524WU7/vdjMGT+hvxXqCE/q+hnQUOKpeEtc2WIp0XukvgW c6Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735476079; x=1736080879; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/gUIxBYTNdKmO7h8yq3Oe9LTVRomBNQ7bx60VPAPgIs=; b=ss07I6rcdIRLjj4O/qaMcOuJqItGV3a26XC5rI709uZwfu0RSMgdaPvf3D8nG1YNMK w53N5Cs52sV1arBFIpxb+yyd25iuVbST/ZD6NDaUo6/d1GO4mmQgQe/lW4KrmeTTJMfC xbJXAGpmiDrn8xSMSMdc7pleXIA8/euOPz6S7FZ7Ql0aJlCgFaUcwMsGoZt6PciRoeZa EWQgAC73yrz1eDYquDiQdbb55zU51p/oM+ajTY8oi/PxPnNVgn0xdVsPeKj1qYoQ6nXf 4J7iGRhiVcZl6NGSBsYBdMry4sNsRQTgkpY3Ps0Ycbxm658XasCwafyTm3vbAybNfZ3n NXBQ== X-Forwarded-Encrypted: i=1; AJvYcCVH1mub8VoTNLu2H7rWk+7/rPoNSiq45325CwFdnh7+cRqk+BxkkJgmHtLE0zaw83f6EHm7IRGJYodQQKw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc0vmcUGGw2SLgJm8wMGS5fMT/ZTexHUV/yJXooLCJPGCn3qBd D3u8ggwrOb7BDuMtmXN7NoA7kn+yzpebxCdk8dmtIv8KPX4Z49IzXKSFwk6eTQ== X-Gm-Gg: ASbGncuwrpSvgma/DgLY4pdbQWjq5RpjCroEnNJBQmuwA8J0wExKHl3pcEtAv6YLpqd cmSlJcadE1+UpBJgamGLT914jx05U+FpN+xnbLX/Ylpy+Hv2N9wD2hLxQdcR03NTKmCxysHTkr1 8J3x7lD2QqBfVLyh6yNnONBVYesUNJKFir8ypuWXuGemPU0NG5el4pNmgSJpdg3VTUjbuHeParP kbwcRERYjTS9vZ98XzaihNPjGB5CRMtYgYw/G0TriGtVl9XDX/5JP6dw/EaFSo1VVJa50HLACiA +sPNJO9o6+2UCRdeELqwbvxYtr+EGk+Rjm6StgfoeAeAmJPM+/MNVsi54sYXUyXY2cx09iRi19b BiZcQn9DQ7fdvo6h/ipU= X-Google-Smtp-Source: AGHT+IFrgzmND0VLnK/1oCJAEzgqKhjQYXe6YlvxqrouxHnxtTU9bEmPo3dg6bFBGDgP7AwQlAG8Dw== X-Received: by 2002:a17:906:6a21:b0:aab:edc2:ccef with SMTP id a640c23a62f3a-aac080fe36dmr2975938266b.2.1735476078594; Sun, 29 Dec 2024 04:41:18 -0800 (PST) Received: from ?IPV6:2003:d9:9728:db00:a504:9f53:5dd9:23c7? (p200300d99728db00a5049f535dd923c7.dip0.t-ipconnect.de. [2003:d9:9728:db00:a504:9f53:5dd9:23c7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f00ea44sm1353800066b.135.2024.12.29.04.41.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Dec 2024 04:41:17 -0800 (PST) Message-ID: Date: Sun, 29 Dec 2024 13:41:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] fs/pipe: Introduce a check to skip sleeping processes during pipe read/write To: Oleg Nesterov Cc: Linus Torvalds , WangYuli , linux-fsdevel , Linux Kernel Mailing List , Christian Brauner References: <75B06EE0B67747ED+20241225094202.597305-1-wangyuli@uniontech.com> <20241226201158.GB11118@redhat.com> <1df49d97-df0e-4471-9e40-a850b758d981@colorfullife.com> <20241228143248.GB5302@redhat.com> <20241228152229.GC5302@redhat.com> <20241229115741.GB27491@redhat.com> Content-Language: en-US From: Manfred Spraul In-Reply-To: <20241229115741.GB27491@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleg, On 12/29/24 12:57 PM, Oleg Nesterov wrote: > On 12/28, Manfred Spraul wrote: >> On 12/28/24 4:22 PM, Oleg Nesterov wrote: >>> Now suppose that another CPU executes wake() between LOAD(CONDITION) >>> and list_add(entry, head). With your patch wait() will miss the event. >>> The same for __pollwait(), I think... > ... > >> It could still work for prepare_to_wait and thus fs/pipe, since then the >> smb_mb() in set_current_state prevents earlier execution. From now, I'll try to follow standard patterns: every memory barrier must be paired. And adding barriers to common functions for potentially rare situations is now allowed. (unless it is a bugfix). And then enumerate all codepaths: For the wait_event users: We have a smp_mb() in prepare_to_wait(), it could pair with the barrier in wq_has_sleepers(). > Not sure, please see the note about __pollwait() above. > > I think that your patch (and the original patch from WangYuli) has the same > proble with pipe_poll()->poll_wait()->__pollwait(). What is the memory barrier for pipe_poll()? There is poll_wait()->__pollwait()->add_wait_queue()->spin_unlock(). thus only store_release. And then READ_ONCE(), i.e. no memory barrier. Thus the CPU would be free to load pipe->head and pipe->tail before adding the entry to the poll table. Correct? --     Manfred