From: Paolo Abeni <pabeni@redhat.com>
To: Jijie Shao <shaojijie@huawei.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: shenjian15@huawei.com, wangpeiyang1@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
sudongming1@huawei.com, xujunsheng@huawei.com,
shiyongbang@huawei.com, libaihan@huawei.com, andrew@lunn.ch,
jdamato@fastly.com, horms@kernel.org,
kalesh-anakkur.purayil@broadcom.com,
christophe.jaillet@wanadoo.fr, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V12 net-next 07/10] net: hibmcge: Implement rx_poll function to receive packets
Date: Tue, 15 Oct 2024 13:57:07 +0200 [thread overview]
Message-ID: <ee1205d6-3d6b-447f-991e-903936d45ac7@redhat.com> (raw)
In-Reply-To: <44023e6f-5a52-4681-84fc-dd623cd9f09d@huawei.com>
On 10/15/24 13:41, Jijie Shao wrote:
> on 2024/10/15 18:28, Paolo Abeni wrote:
>> Side note: the above always uses the maximum MTU for the packet size,
>> if the device supports jumbo frames (8Kb size packets), it will
>> produce quite bad layout for the incoming packets... Is the device
>> able to use multiple buffers for the incoming packets?
>
> In fact, jumbo frames are not supported in device, and the maximum MTU is 4Kb.
FTR, even 4Kb is bad enough: tiny packets (tcp syn, UDP dns req) will
use a truesize above 5K. You can get a much better the layout using
copybreak.
Cheers,
Paolo
next prev parent reply other threads:[~2024-10-15 11:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 14:21 [PATCH V12 net-next 00/10] Add support of HIBMCGE Ethernet Driver Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 01/10] net: hibmcge: Add pci table supported in this module Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 02/10] net: hibmcge: Add read/write registers supported through the bar space Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 03/10] net: hibmcge: Add mdio and hardware configuration supported in this module Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 04/10] net: hibmcge: Add interrupt " Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 05/10] net: hibmcge: Implement some .ndo functions Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 06/10] net: hibmcge: Implement .ndo_start_xmit function Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 07/10] net: hibmcge: Implement rx_poll function to receive packets Jijie Shao
2024-10-15 10:28 ` Paolo Abeni
2024-10-15 11:41 ` Jijie Shao
2024-10-15 11:57 ` Paolo Abeni [this message]
2024-10-15 12:05 ` Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 08/10] net: hibmcge: Implement some ethtool_ops functions Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 09/10] net: hibmcge: Add a Makefile and update Kconfig for hibmcge Jijie Shao
2024-10-10 14:21 ` [PATCH V12 net-next 10/10] net: hibmcge: Add maintainer " Jijie Shao
2024-10-15 10:30 ` Paolo Abeni
2024-10-15 11:43 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee1205d6-3d6b-447f-991e-903936d45ac7@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jonathan.cameron@huawei.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®