From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FCAC4332F for ; Wed, 13 Dec 2023 01:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378052AbjLMBD5 (ORCPT ); Tue, 12 Dec 2023 20:03:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbjLMBDy (ORCPT ); Tue, 12 Dec 2023 20:03:54 -0500 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8F67799; Tue, 12 Dec 2023 17:03:58 -0800 (PST) Received: from loongson.cn (unknown [111.207.111.194]) by gateway (Coremail) with SMTP id _____8DxS+n6Anll6H4AAA--.3111S3; Wed, 13 Dec 2023 09:03:54 +0800 (CST) Received: from [10.180.13.176] (unknown [111.207.111.194]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cx73PyAnllSIoBAA--.10143S3; Wed, 13 Dec 2023 09:03:47 +0800 (CST) Subject: Re: [PATCH v2] PM: hibernate: use acquire/release ordering when compress/decompress image To: "Rafael J. Wysocki" Cc: Len Brown , Pavel Machek , Bojan Smojver , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn, stable@vger.kernel.org, Weihao Li References: <20231116005609.1583858-1-zhanghongchen@loongson.cn> From: Hongchen Zhang Message-ID: Date: Wed, 13 Dec 2023 09:02:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8Cx73PyAnllSIoBAA--.10143S3 X-CM-SenderInfo: x2kd0w5krqwupkhqwqxorr0wxvrqhubq/1tbiAQAEB2V3wy0JQgABs0 X-Coremail-Antispam: 1Uk129KBj93XoW3Ar15Ar47KrWruFyktr1DArc_yoWxKw15pF Z5Xan0kF4UJFW5AwsFva10v345AwnYyFZrGrs3Ja4fuasIgws5ta40gF9Yvr1YyF1xKa40 9a1Utr90gryqvFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUx529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWU twAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx k0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vIr41l 4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_JF0_Jw1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j5o7tUUUUU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, Thanks for your review. On 2023/12/12 下午9:03, Rafael J. Wysocki wrote: > On Thu, Nov 16, 2023 at 1:56 AM Hongchen Zhang > wrote: >> >> When we test S4(suspend to disk) on LoongArch 3A6000 platform, the >> test case sometimes fails. The dmesg log shows the following error: >> Invalid LZO compressed length >> After we dig into the code, we find out that: >> When compress/decompress the image, the synchronization operation >> between the control thread and the compress/decompress/crc thread >> uses relaxed ordering interface, which is unreliable, and the >> following situation may occur: >> CPU 0 CPU 1 >> save_image_lzo lzo_compress_threadfn >> atomic_set(&d->stop, 1); >> atomic_read(&data[thr].stop) >> data[thr].cmp = data[thr].cmp_len; >> WRITE data[thr].cmp_len >> Then CPU0 get a old cmp_len and write to disk. When cpu resume from S4, >> wrong cmp_len is loaded. >> >> To maintain data consistency between two threads, we should use the >> acquire/release ordering interface. So we change atomic_read/atomic_set >> to atomic_read_acquire/atomic_set_release. >> >> Fixes: 081a9d043c98 ("PM / Hibernate: Improve performance of LZO/plain hibernation, checksum image") >> Cc: stable@vger.kernel.org >> Signed-off-by: Hongchen Zhang >> Signed-off-by: Weihao Li > > I was about to apply this patch when I noticed the S-o-b confusion. > > Either a From: header pointing to Weihao Li is > missing and the Hongchen Zhang sign-off > means that the patch is sent on behalf of Weihao Li, or you both > worked on the patch together and a Co-developed-by: tag pointing to > Weihao Li is missing. > > Which of the above is the case? Yes, we both worked on this patch,let me add Co-developed-by: Weihao Li and send V3. > >> --- >> v1 -> v2: >> 1. add Cc: stable@vger.kernel.org in commit log >> 2. add Fixes: line in commit log >> --- >> kernel/power/swap.c | 38 +++++++++++++++++++------------------- >> 1 file changed, 19 insertions(+), 19 deletions(-) >> >> diff --git a/kernel/power/swap.c b/kernel/power/swap.c >> index a2cb0babb5ec..d44f5937f1e5 100644 >> --- a/kernel/power/swap.c >> +++ b/kernel/power/swap.c >> @@ -606,11 +606,11 @@ static int crc32_threadfn(void *data) >> unsigned i; >> >> while (1) { >> - wait_event(d->go, atomic_read(&d->ready) || >> + wait_event(d->go, atomic_read_acquire(&d->ready) || >> kthread_should_stop()); >> if (kthread_should_stop()) { >> d->thr = NULL; >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> break; >> } >> @@ -619,7 +619,7 @@ static int crc32_threadfn(void *data) >> for (i = 0; i < d->run_threads; i++) >> *d->crc32 = crc32_le(*d->crc32, >> d->unc[i], *d->unc_len[i]); >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> } >> return 0; >> @@ -649,12 +649,12 @@ static int lzo_compress_threadfn(void *data) >> struct cmp_data *d = data; >> >> while (1) { >> - wait_event(d->go, atomic_read(&d->ready) || >> + wait_event(d->go, atomic_read_acquire(&d->ready) || >> kthread_should_stop()); >> if (kthread_should_stop()) { >> d->thr = NULL; >> d->ret = -1; >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> break; >> } >> @@ -663,7 +663,7 @@ static int lzo_compress_threadfn(void *data) >> d->ret = lzo1x_1_compress(d->unc, d->unc_len, >> d->cmp + LZO_HEADER, &d->cmp_len, >> d->wrk); >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> } >> return 0; >> @@ -798,7 +798,7 @@ static int save_image_lzo(struct swap_map_handle *handle, >> >> data[thr].unc_len = off; >> >> - atomic_set(&data[thr].ready, 1); >> + atomic_set_release(&data[thr].ready, 1); >> wake_up(&data[thr].go); >> } >> >> @@ -806,12 +806,12 @@ static int save_image_lzo(struct swap_map_handle *handle, >> break; >> >> crc->run_threads = thr; >> - atomic_set(&crc->ready, 1); >> + atomic_set_release(&crc->ready, 1); >> wake_up(&crc->go); >> >> for (run_threads = thr, thr = 0; thr < run_threads; thr++) { >> wait_event(data[thr].done, >> - atomic_read(&data[thr].stop)); >> + atomic_read_acquire(&data[thr].stop)); >> atomic_set(&data[thr].stop, 0); >> >> ret = data[thr].ret; >> @@ -850,7 +850,7 @@ static int save_image_lzo(struct swap_map_handle *handle, >> } >> } >> >> - wait_event(crc->done, atomic_read(&crc->stop)); >> + wait_event(crc->done, atomic_read_acquire(&crc->stop)); >> atomic_set(&crc->stop, 0); >> } >> >> @@ -1132,12 +1132,12 @@ static int lzo_decompress_threadfn(void *data) >> struct dec_data *d = data; >> >> while (1) { >> - wait_event(d->go, atomic_read(&d->ready) || >> + wait_event(d->go, atomic_read_acquire(&d->ready) || >> kthread_should_stop()); >> if (kthread_should_stop()) { >> d->thr = NULL; >> d->ret = -1; >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> break; >> } >> @@ -1150,7 +1150,7 @@ static int lzo_decompress_threadfn(void *data) >> flush_icache_range((unsigned long)d->unc, >> (unsigned long)d->unc + d->unc_len); >> >> - atomic_set(&d->stop, 1); >> + atomic_set_release(&d->stop, 1); >> wake_up(&d->done); >> } >> return 0; >> @@ -1335,7 +1335,7 @@ static int load_image_lzo(struct swap_map_handle *handle, >> } >> >> if (crc->run_threads) { >> - wait_event(crc->done, atomic_read(&crc->stop)); >> + wait_event(crc->done, atomic_read_acquire(&crc->stop)); >> atomic_set(&crc->stop, 0); >> crc->run_threads = 0; >> } >> @@ -1371,7 +1371,7 @@ static int load_image_lzo(struct swap_map_handle *handle, >> pg = 0; >> } >> >> - atomic_set(&data[thr].ready, 1); >> + atomic_set_release(&data[thr].ready, 1); >> wake_up(&data[thr].go); >> } >> >> @@ -1390,7 +1390,7 @@ static int load_image_lzo(struct swap_map_handle *handle, >> >> for (run_threads = thr, thr = 0; thr < run_threads; thr++) { >> wait_event(data[thr].done, >> - atomic_read(&data[thr].stop)); >> + atomic_read_acquire(&data[thr].stop)); >> atomic_set(&data[thr].stop, 0); >> >> ret = data[thr].ret; >> @@ -1421,7 +1421,7 @@ static int load_image_lzo(struct swap_map_handle *handle, >> ret = snapshot_write_next(snapshot); >> if (ret <= 0) { >> crc->run_threads = thr + 1; >> - atomic_set(&crc->ready, 1); >> + atomic_set_release(&crc->ready, 1); >> wake_up(&crc->go); >> goto out_finish; >> } >> @@ -1429,13 +1429,13 @@ static int load_image_lzo(struct swap_map_handle *handle, >> } >> >> crc->run_threads = thr; >> - atomic_set(&crc->ready, 1); >> + atomic_set_release(&crc->ready, 1); >> wake_up(&crc->go); >> } >> >> out_finish: >> if (crc->run_threads) { >> - wait_event(crc->done, atomic_read(&crc->stop)); >> + wait_event(crc->done, atomic_read_acquire(&crc->stop)); >> atomic_set(&crc->stop, 0); >> } >> stop = ktime_get(); >> -- >> 2.33.0 >> -- Best Regards Hongchen Zhang