From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v5 3/4] scsi: ufs: core: Introduce a new clock_gating lock
Date: Mon, 25 Nov 2024 13:35:45 -0800 [thread overview]
Message-ID: <ee1eaed1-3ce5-4037-a385-18febab695a0@acm.org> (raw)
In-Reply-To: <20241124070808.194860-4-avri.altman@wdc.com>
On 11/23/24 11:08 PM, Avri Altman wrote:
> Introduce a new clock gating lock to serialize access to some of the
> clock gating members instead of the host_lock.
>
> While at it, simplify the code with the guard() macro and co for
> automatic cleanup of the new lock. There are some explicit
> spin_lock_irqsave/spin_unlock_irqrestore snaking instances I left behind
> because I couldn't make heads or tails of it.
>
> Additionally, move the trace_ufshcd_clk_gating() call from inside the
> region protected by the lock as it doesn't needs protection.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-11-25 21:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 7:08 [PATCH v5 0/4] Untie the host lock entanglement - part 2 Avri Altman
2024-11-24 7:08 ` [PATCH v5 1/4] scsi: ufs: core: Introduce ufshcd_has_pending_tasks Avri Altman
2024-11-25 21:28 ` Bart Van Assche
2024-11-24 7:08 ` [PATCH v5 2/4] scsi: ufs: core: Prepare to introduce a new clock_gating lock Avri Altman
2024-11-25 21:30 ` Bart Van Assche
2024-11-24 7:08 ` [PATCH v5 3/4] scsi: ufs: core: Introduce " Avri Altman
2024-11-25 21:35 ` Bart Van Assche [this message]
2025-01-21 12:42 ` Manivannan Sadhasivam
2025-01-21 12:46 ` Manivannan Sadhasivam
2025-01-21 13:24 ` Avri Altman
2024-11-24 7:08 ` [PATCH v5 4/4] scsi: ufs: core: Introduce a new clock_scaling lock Avri Altman
2024-12-04 18:13 ` [PATCH v5 0/4] Untie the host lock entanglement - part 2 Martin K. Petersen
2024-12-10 2:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee1eaed1-3ce5-4037-a385-18febab695a0@acm.org \
--to=bvanassche@acm.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®