From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B40CD423782 for ; Thu, 30 Jul 2026 11:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412774; cv=none; b=qcdgh3kxFESGFyX8vm+BWywhrsHETaZ5HpbxEaZd8L5AhT8hkhrtW2SRqunSwtrKvedms2U7mefHoQdWOq4YaXbkAxXLNHNYEdshbEY1kC0T0Q2fQd6N61xE+2tIERrJtm0aclMbakU22Det+m5K7ocZ3BVrtJsNdOaQzncxd/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412774; c=relaxed/simple; bh=NoxRCcgEgb06epQxvvw2a85CLBOzEBByEaQUWYnXeDc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bd4AK7PBey27ze9r6/3uPiK2WIVHtxNHVtegrvSnA+sZFkVSO1jE5zoLRKkDzbtW3XaVuN2R8lmqiE2JH3HgJJyvQbRrBqf0WyXMYxjvdldytlpovgo7qXTUxx1JBpuekmEgsHY1TsujT822/vDsHnPTtLwXBEScZ363xoNDflo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hgf4Or5+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gwHvC/Ca; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hgf4Or5+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gwHvC/Ca" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UBW7B81144169 for ; Thu, 30 Jul 2026 11:59:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FBp2w12lai0FjiEpU3v2YGIn15VLtuFjmO2fx6m51K0=; b=Hgf4Or5+CB1nNkn1 ZfCPnnCqJ1dMySNQ/AZF38CTRN27kGa/vGd6P7EM1+zKce3eDJ7avdCXTJttIhsY 2PjFvvmR/zlzxWCDuvoUO9WlHMV/L0AkaEQs4MwUivlrx+QgrLuxC/KutmE+E2pR 8MRjEFh5nqFZqWTHwTAmjYJHINM5kyfJimT42icbAxsVvR+id9THGNTET3nbK1HE 6ODWwjUJVBAnZDO/cCknpfS+r/FMF1jWTvHTL4lYXUnzwcfOT1OEbpIwwS/Qs7m6 gmz5djwVSeDw1sSitCYxQYqPEvJFGGNRusaDdNb31a0Hl2JINsnmz9yRiYJgjCue OBNBmQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr5tvr30a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 11:59:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5174a236220so20466391cf.3 for ; Thu, 30 Jul 2026 04:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785412771; x=1786017571; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FBp2w12lai0FjiEpU3v2YGIn15VLtuFjmO2fx6m51K0=; b=gwHvC/CamFiyMY7tfpb4jyUD4zHTAuP2jvIvOlxV0pDBbqwn2dSRp4sbc3RSfgYErB j+VpiW5/cXSR7EuWWrjkqs+OxAjpN7rE7Ld5F1Ka0cePLLbJ8iectWnVoFWzHx109LWF gNCsyZJzAvc4FtzppLirwV8rtQKI5mKDMJcMrVjBQEdOLg7emPYuOzxb9pyf/vI5OEOy ghzVF7IMoDg2ASaurLinBymcoG6r1Ed2586cwzmxBdP3HkyLcoGUVtnezcqVhnpD5poi c5BjzFquajtYdMDcxtFJtcma98mCYJ388QA9K/WkkvAhONOzRXdbt5Sqb1Gn1AKLeBrf zVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785412771; x=1786017571; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FBp2w12lai0FjiEpU3v2YGIn15VLtuFjmO2fx6m51K0=; b=cR7SlZ7QJ0bJQYB2lfLe5X8UF/L7gE5DTzpAoju4mcJuNNli00zXzM8ILjXiSn2LVk JfVdbugtPfR/s5V/GOeDBL+vHhl/0dkylRFc9B5l3EoP2AjcFabHdJjnErhuEFXnj314 sSwaOA0lAGpAkrT/BrUCP+EsC8ruH4e2IWz56KmwEw7TJqVvV6Iz6JO4lHGcJ94xivbB OSEWn82T03USmrLGKX47LPwOPaiUKor6xdyJsq413a1SoXTWI5jQqWHbDxNFMVDC8zXZ ZlQ0Jpak16yyB6Q+AzsnHdsZSUAlTU93pFQlPQeLrdZ7iIIIa4BIfl5D7zlwCH4D7ooT vlow== X-Forwarded-Encrypted: i=1; AHgh+Rq+sy1wbbPnfVwENgXUh6WzVEYaf6fUcBeGpDosBeHTbI0gfL+9COJpkjVFS05WzT5xbiw293SUGoRDzRA=@vger.kernel.org X-Gm-Message-State: AOJu0YyxTXeevyIZXfplUKkED538zTlNyn0Mq3VlxCjnQliFKNX3FBXu zhPFJpFz1++ALN8V6iE/tg2PnZQTJVC2EJw0X0Rm8rUPy6ttQMT4yARPiWUfQFi2pLNjxZUzj7L XYd1aSJqjYFgge53hTnD4zUE+1OWeJSmwiOZvL1SvJVa32i+DXcns3EOTD3Sz38i+x5s= X-Gm-Gg: AR+sD11/mQjQBszstuS//RyObvBQdb5pYYDe6GZnJ9O1ghMbzrnCOdOmgFi3USFI4vU B1w4QyaDdATBA08CzoBoOoejSmXPPmWNf3Av8HhW+G8pkNXh9UcfruAeCuLeaC/6bpGgffr1Cyr vFsc25NHAHsch/Kur8r9TI41EbDMzVr1MwJ3TJaOI8am/OcoH9Mzx3XTQPzRyiDls72u17yF7Xq WXh2T6Rzj4269g8YXbOeG1BVbovjPZ2eSJjqAREkb0opddLx8l4uXrk+x0Sjy+3SsuyEhtW+EGO HvUkxO0SlgeaNJSxvs6c5HlmjX6Tua9qk4mxMncDv6WswwUBHrl9/81QDeyRuDzQkbXGT4wRqO0 6VqVoIL3yMP7+EiUk/ST2XDq1iHo= X-Received: by 2002:ac8:6f17:0:b0:51c:7b13:62f9 with SMTP id d75a77b69052e-52b38742986mr24485491cf.79.1785412770700; Thu, 30 Jul 2026 04:59:30 -0700 (PDT) X-Received: by 2002:ac8:6f17:0:b0:51c:7b13:62f9 with SMTP id d75a77b69052e-52b38742986mr24485201cf.79.1785412770205; Thu, 30 Jul 2026 04:59:30 -0700 (PDT) Received: from [192.168.68.105] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-c1fa8577e6dsm59312266b.22.2026.07.30.04.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 04:59:29 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 12:59:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] ASoC: codecs: lpass-{tx,wsa}-macro: fix enum kcontrol accesses To: me@dawidwrobel.com, Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260730-worktree-lpass-tx-macro-enum-fix-v2-0-6d091c736116@dawidwrobel.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260730-worktree-lpass-tx-macro-enum-fix-v2-0-6d091c736116@dawidwrobel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA5MCBTYWx0ZWRfXxLHxbzRVNxxQ SSB9ZxRwnswQx6blpLeWLFKJNlACt39Yg4eLTdFV/ceyVQiUQs+OkwYSZlfHnQy1+j1qbWO9jtC QCdvaYtidTDTz0qTNpFEkXcpNyQGqjE= X-Proofpoint-ORIG-GUID: pDkxx-UfWBIqvjyisjseR2u0gg-Znj84 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA5MCBTYWx0ZWRfX37XndfPlFLY6 jJpsg7bMLdJjrk4s8AM0rPGrRKH9CYytB+Tp3jGTaxW44F0g0GXBcxPROWrHtGLMY9//9VdLsWz X/yfCyArRhznLkXPpgYX0WGuFWY8qn5y6RFIa7vP3dwLZ+GJ/mR3mJBRAaOp2KsvCVBJBjS+Azy +XQWZBAtJptFtK13UslR2NJ5yM8DPKVwvFPAovSaWDQBjjHSrffB5E+E4dIBtMbYay2ohpepAiP p/bK2NNnkX1LpPNIBEUHsdjAw+7e+F7iPzkmvw5gLkRPIcpSl57eB7u+coiL3c//zaITcL4ve/B 7C+ioC+UesUrM72KukI1FxU3CbLW/Yjb2ksS3vdBcMjzVBYYAihE6s4EnU4nnaqDqBfP3Pd/q/U rR+//8ZbQo4ogzKcWJIVUhWQu1xndtuVv9gogNfuJXaGk4VOkSGm1QodAXMytjs8wNCWsuE9Z2m nhhiMljGGJ1FiRrDLDw== X-Authority-Analysis: v=2.4 cv=ULPt2ify c=1 sm=1 tr=0 ts=6a6b3ca3 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=br21HGidAAAA:8 a=EUspDBNiAAAA:8 a=pIAsNjLqZIIOTrGnJRYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=rq5_1Q1BYlbxkLLkNd_B:22 X-Proofpoint-GUID: pDkxx-UfWBIqvjyisjseR2u0gg-Znj84 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_03,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300090 On 7/30/26 11:58 AM, Dawid Wróbel via B4 Relay wrote: > Both drivers access enumerated controls through value.integer.value[0] > instead of value.enumerated.item[0]. The same bug was fixed in rx-macro > and va-macro in 2022 (bcfe5f76cc40, 0ea5eff7c606); tx-macro and > wsa-macro were missed. > > On 64-bit kernels with CONFIG_SND_CTL_DEBUG this trips the elem value > sanity check, and every read of the affected controls fails with > -EINVAL. > > Reproduced and fixed on a Xiaomi Mi Pad 5 Pro (SM8250) for tx-macro. > wsa-macro is compile-tested only — that codec is not instantiated on > this hardware. > > Signed-off-by: Dawid Wróbel > --- LGTM, Reviewed-by: Srinivas Kandagatla --srini > Changes in v2: > - wsa-macro: also fix wsa_macro_rx_mux_get() and wsa_macro_rx_mux_put(), > which have the same bug (Srinivas Kandagatla) > - Cc stable on both patches (Srinivas Kandagatla) > - Link to v1: https://lore.kernel.org/r/20260729-worktree-lpass-tx-macro-enum-fix-v1-0-0cf02c681332@dawidwrobel.com > > --- > Dawid Wróbel (2): > ASoC: codecs: lpass-tx-macro: Fix enum kcontrol accesses > ASoC: codecs: lpass-wsa-macro: Fix enum kcontrol accesses > > sound/soc/codecs/lpass-tx-macro.c | 4 ++-- > sound/soc/codecs/lpass-wsa-macro.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > --- > base-commit: 57b8e2d666a31fa201432d58f5fe3469a0dd83ba > change-id: 20260729-worktree-lpass-tx-macro-enum-fix-c5fbafef75b6 > > Best regards,