From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbdLKS4q (ORCPT ); Mon, 11 Dec 2017 13:56:46 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51465 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbdLKS4m (ORCPT ); Mon, 11 Dec 2017 13:56:42 -0500 Subject: Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) To: Richard Weinberger , Daniel Borkmann Cc: "netdev@vger.kernel.org" , Linus Torvalds , Linux Kernel Mailing List , alexei.starovoitov@gmail.com, brueckner@linux.vnet.ibm.com References: <7534692.EB8JgYtGIt@blindfold> <1879970.PcO3yMVeYC@blindfold> From: Randy Dunlap Message-ID: Date: Mon, 11 Dec 2017 10:56:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1879970.PcO3yMVeYC@blindfold> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2017 10:49 AM, Richard Weinberger wrote: > Am Montag, 11. Dezember 2017, 11:19:54 CET schrieb Daniel Borkmann: >> Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] >> >> On 12/11/2017 09:32 AM, Richard Weinberger wrote: >>> Randy, >>> >>> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>>> Another week, another rc. >>>> >>>> um (uml) won't build on i386 or x86_64: >>>> CC init/main.o >>>> >>>> In file included from ../include/linux/perf_event.h:18:0, >>>> >>>> from ../include/linux/trace_events.h:10, >>>> from ../include/trace/syscall.h:7, >>>> from ../include/linux/syscalls.h:82, >>>> >>>> from ../init/main.c:20: >>>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >>>> asm/bpf_perf_event.h: No such file or directory #include >>>> >>>> >>>> ^ >>>> >>>> compilation terminated. >>>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed >>> >>> How do you trigger that build failure? >>> Can you share your .config? >> >> Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar >> with uml, but looks like it's the only special case where there's no >> arch/um/include/uapi/asm/. What is the usual convention to pull in such >> headers in this case? Something like the below, would that fix it for you? >> >> Thanks for your help, >> Daniel >> >> arch/um/include/asm/bpf_perf_event.h | 1 + >> include/asm-generic/bpf_perf_event.h | 1 + >> 2 files changed, 2 insertions(+) >> create mode 100644 arch/um/include/asm/bpf_perf_event.h >> create mode 100644 include/asm-generic/bpf_perf_event.h >> >> diff --git a/arch/um/include/asm/bpf_perf_event.h >> b/arch/um/include/asm/bpf_perf_event.h new file mode 100644 >> index 0000000..3097758 >> --- /dev/null >> +++ b/arch/um/include/asm/bpf_perf_event.h >> @@ -0,0 +1 @@ >> +#include >> diff --git a/include/asm-generic/bpf_perf_event.h >> b/include/asm-generic/bpf_perf_event.h new file mode 100644 >> index 0000000..67112e5 >> --- /dev/null >> +++ b/include/asm-generic/bpf_perf_event.h >> @@ -0,0 +1 @@ >> +#include > > Hmm, what about this? > > diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild > index 50a32c33d729..fb35ec000433 100644 > --- a/arch/um/include/asm/Kbuild > +++ b/arch/um/include/asm/Kbuild > @@ -27,3 +27,4 @@ generic-y += trace_clock.h > generic-y += word-at-a-time.h > generic-y += xor.h > generic-y += kprobes.h > +generic-y += bpf_perf_event.h > That also works for arch/um. thanks, -- ~Randy