From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934386AbdERPwZ (ORCPT ); Thu, 18 May 2017 11:52:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932601AbdERPwV (ORCPT ); Thu, 18 May 2017 11:52:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B269F7700 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=longman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B269F7700 Subject: Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file To: Tejun Heo References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-9-git-send-email-longman@redhat.com> <20170517213603.GE942@htj.duckdns.org> Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de From: Waiman Long Organization: Red Hat Message-ID: Date: Thu, 18 May 2017 11:52:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170517213603.GE942@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 18 May 2017 15:52:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into its own file as it will no longer >> be v1 specific. The only change in this patch is the expansion of >> cgroup_task_count() within the debug_taskcount_read() function. >> >> Signed-off-by: Waiman Long > I don't mind enabling the debug controller for v2 but let's please > hide it behind an unwieldy boot param / controller name so that it's > clear that its interface isn't expected to be stable. > > Thanks. > The controller name is "debug" and so it is obvious what this controller is for. However, the config prompt "Example controller" is indeed vague in meaning. So we can make the prompt more descriptive here. As for the boot param, are you saying something like "cgroup_debug" has to be specified in the command line even if CGROUP_DEBUG config is there for the debug controller to be enabled? I am fine with that if you think it is necessary. Regards, Longman